This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Fixed bug that caused the PDO to throw an invalid keyword error#5069
Merged
ralphschindler merged 1 commit intoDec 3, 2013
Merged
Fixed bug that caused the PDO to throw an invalid keyword error#5069ralphschindler merged 1 commit into
ralphschindler merged 1 commit into
Conversation
Member
|
This is another case where we really need some tests, but this particular class wasn't really written to be easily testable, unfortunately. :-/ We need to figure out if we're going to accept PR's without tests in this case or try to make the class a bit more testable. |
Contributor
Author
|
We could test up to the point where it cannot connect to the server. Basically the test would check for the issue that is being fixed by the PR. I was thinking something like this |
Member
|
I'll be looking into supporting SQL Server via PDO, which we currently don't. |
ralphschindler
pushed a commit
that referenced
this pull request
Dec 3, 2013
Merge branch 'fix/zend-db-adapter-driver-pdo' of git://github.com/brian978/zf2 into brian978-fix/zend-db-adapter-driver-pdo * 'fix/zend-db-adapter-driver-pdo' of git://github.com/brian978/zf2: Fixed bug that caused the PDO to throw an invalid keyword error
ralphschindler
pushed a commit
that referenced
this pull request
Dec 3, 2013
Merge branch 'brian978-fix/zend-db-adapter-driver-pdo' into develop * brian978-fix/zend-db-adapter-driver-pdo: Added some integration tests for PDO driver Statement & Connection class Fixed bug that caused the PDO to throw an invalid keyword error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the special case for the sqlsrv driver a PDOException with the following message is thrown: SQLSTATE[IMSSP]: An invalid keyword 'dbname' was specified in the DSN string.