This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Ensure DiAbstractServiceFactory takes lowest possible priority#5180
Closed
grncdr wants to merge 1 commit into
Closed
Ensure DiAbstractServiceFactory takes lowest possible priority#5180grncdr wants to merge 1 commit into
grncdr wants to merge 1 commit into
Conversation
A `Zend\Di` abstract factory should always be checked *after* abstract factories from modules.
Contributor
Author
|
The Travis failure above looks unrelated: https://travis-ci.org/zendframework/zf2/jobs/11851852#L183 |
Member
|
👍 to this |
Contributor
Author
|
Who do I need to @ reply on this to get it merged? |
Member
|
@grncdr you need to wait for someone of the CR team. If you rely on it, then please use your fork for now. |
Member
|
Can you add tests for this -- essentially, show adding other abstract factories around adding this will result in DI being the last called? I worry we'll miss this in a future changeset. |
Member
|
Actually, belay that last comment. Merging. |
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
Ensure DiAbstractServiceFactory takes lowest possible priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm far from expert on all the intricacies of Zend\Di, but this
seemed necessary for my application.
AFAICT, the
Zend\ServiceManager\Di\DiAbstractServiceFactorywill be lazily added to the shared ServiceManager at an unpredictable
time. The default behaviour of
addAbstractFactoryputs this newabstract factory in front of abstract factories from modules, which leads
to the DiAbstractFactory trying to create things before module-defined
abstract factories get a chance.