This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Fix/form label options#5226
Merged
weierophinney merged 3 commits intoOct 23, 2013
Merged
Conversation
…also work for multi option elements.
Contributor
|
Good catch! Can you provide a test? |
Member
public function testDisableEscapeHtmlHelper()
{
$element = new MultiCheckboxElement('foo');
$element->setLabelOptions(
array(
'disable_html_escape' => true,
)
);
$element->setValueOptions(
array(
array(
'label' => '<span>label1</span>',
'value' => 'value1',
),
)
);
$this->assertEquals(
'<label><input type="checkbox" name="foo[]" value="value1"><span>label1</span></label>',
$this->helper->render($element)
);
} |
Contributor
Author
|
test added. thanks @froschdesign |
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently added label option "disable_html_escape" (#4677) should also work for multi option elements.