This repository was archived by the owner on Jan 8, 2020. It is now read-only.
fix for fprg#5497
Closed
Kill0p wants to merge 2 commits into
Closed
Conversation
Member
|
Please add a unit test case |
weierophinney
added a commit
that referenced
this pull request
Mar 3, 2014
- function declaration, braces, whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got problem when i make collection for my form. My collection has target_element which can be added few times. I use fileprg because this form also contains file inputs.
When we use form without fileprg plugin everything is fine and added elements to collection are validated but after we make form with fileprg plus we have new elements added to collection, those new elements are not validated at all. I dig in and realized that getInputFilter() function in handleGetRequest() doesnt add InputFilters to form for new elements.
It doesnt know about it because form only contains information from the configuration of form. If we set 'count' => 1 in options of collection it will validate only first element.