This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Specify correct return type for Pdo\Connection::getLastGeneratedValue#5508
Closed
irnc wants to merge 1 commit into
Closed
Specify correct return type for Pdo\Connection::getLastGeneratedValue#5508irnc wants to merge 1 commit into
Pdo\Connection::getLastGeneratedValue#5508irnc wants to merge 1 commit into
Conversation
See http://php.net/manual/en/pdo.lastinsertid.php for reference that it returns `sting` instead of `int`. TODO: change type of `$lastInsertValue` property and `getLastInsertValue` method in `Zend/Db/TableGateway/AbstractTableGateway.php` accordingly.
Member
|
Is this PR a WIP, or ready to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See http://php.net/manual/en/pdo.lastinsertid.php for reference that it returns
stinginstead ofint.TODO: change type of
$lastInsertValueproperty andgetLastInsertValuemethod inZend/Db/TableGateway/AbstractTableGateway.phpaccordingly.