Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox #5562

Merged
weierophinney merged 2 commits into from
Mar 4, 2014
Merged

Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox #5562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cf0e0d
Added unsetValueOption() to the Form\Element\Select and Form\Element\…
bacinsky Dec 2, 2013
1852f28
Updated Form\Element\Select & MultiCheckbox, fixed unsetValueOption()…
bacinsky Dec 3, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions library/Zend/Form/Element/MultiCheckbox.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,19 @@ public function setValueOptions(array $options)
return $this;
}

/**
* @param string $key
* @return self
*/
public function unsetValueOption($key)
{
if (isset($this->valueOptions[$key])) {
unset($this->valueOptions[$key]);
}

return $this;
}

/**
* Set options for an element. Accepted options are:
* - label: label to associate with the element
Expand Down
13 changes: 13 additions & 0 deletions library/Zend/Form/Element/Select.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,19 @@ public function setValueOptions(array $options)
return $this;
}

/**
* @param string $key
* @return self
*/
public function unsetValueOption($key)
{
if (isset($this->valueOptions[$key])) {
unset($this->valueOptions[$key]);
}

return $this;
}

/**
* Set options for an element. Accepted options are:
* - label: label to associate with the element
Expand Down
28 changes: 28 additions & 0 deletions tests/ZendTest/Form/Element/MultiCheckboxTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,32 @@ public function testDisableInputSpecification()
$inputSpec = $element->getInputSpecification();
$this->assertArrayNotHasKey('validators', $inputSpec);
}

public function testUnsetValueOption()
{
$element = new MultiCheckboxElement();
$element->setValueOptions(array(
'Option 1' => 'option1',
'Option 2' => 'option2',
'Option 3' => 'option3',
));
$element->unsetValueOption('Option 2');

$valueOptions = $element->getValueOptions();
$this->assertArrayNotHasKey('Option 2', $valueOptions);
}

public function testUnsetUndefinedValueOption()
{
$element = new MultiCheckboxElement();
$element->setValueOptions(array(
'Option 1' => 'option1',
'Option 2' => 'option2',
'Option 3' => 'option3',
));
$element->unsetValueOption('Option Undefined');

$valueOptions = $element->getValueOptions();
$this->assertArrayNotHasKey('Option Undefined', $valueOptions);
}
}
28 changes: 28 additions & 0 deletions tests/ZendTest/Form/Element/SelectTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,4 +207,32 @@ public function testDisableInputSpecification()
$this->assertArrayNotHasKey('validators', $inputSpec);
}

public function testUnsetValueOption()
{
$element = new SelectElement();
$element->setValueOptions(array(
'Option 1' => 'option1',
'Option 2' => 'option2',
'Option 3' => 'option3',
));
$element->unsetValueOption('Option 2');

$valueOptions = $element->getValueOptions();
$this->assertArrayNotHasKey('Option 2', $valueOptions);
}

public function testUnsetUndefinedValueOption()
{
$element = new SelectElement();
$element->setValueOptions(array(
'Option 1' => 'option1',
'Option 2' => 'option2',
'Option 3' => 'option3',
));
$element->unsetValueOption('Option Undefined');

$valueOptions = $element->getValueOptions();
$this->assertArrayNotHasKey('Option Undefined', $valueOptions);
}

}