[2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3#5604
Conversation
|
Don't forget this guy https://github.com/zendframework/zf2/blob/master/library/Zend/Session/Container.php |
|
@macnibblet done ;) |
|
Ehm, shouldn't you be removing all the class_aliases and using the proper implementation instead ? |
|
You should do a grep on all instances of version_compare in the library folder because there are many more instances |
|
@macnibblet all version_compare checked. I'm not sure about removing class_aliases, any suggestions for it that need to be removed / updated ? |
|
The reason that we have class_aliases is because we need to fix a bug in PHP, if we bump the minor version we don't need to use those fixes thus they should be removed... |
|
@macnibblet updated. please let me know if I missed something ^^ |
|
@macnibblet wait, last commit cause travis error because I remove class_aliases, I will reset it and check again. |
|
You are going to need to fix tests aswell :) |
|
@macnibblet updated. travis green again ;) |
There was a problem hiding this comment.
I think that whole block can go away now.
There was a problem hiding this comment.
I'm not sure about it //cc @weierophinney
There was a problem hiding this comment.
@gws I think ubuntu check should still exist because version_compare is check for PHP_VERSION >= 5.3.10 , not < , so, the conditional still valid, and we need to only remove the version_compare check because we are already in PHP_VERSION >= 5.3.23. /cc @weierophinney
There was a problem hiding this comment.
My thinking: the PHP version requirements in ZF2 are now beyond the magic database change in 5.3.11 for the 5.3.x line, regardless of Ubuntu's backport to 5.3.10. The only remaining supported version which requires the old magic file format is 5.4.0, which is tested for in the first block.
There was a problem hiding this comment.
@weierophinney any suggestions for this ?
There was a problem hiding this comment.
@gws Ok, now removed as your suggestion. thanks.
|
rebased agains develop cause #5724 |
|
@Maks3w done ;) |
|
@Maks3w removed ;) |
|
@Maks3w done, now removed, I did : Please let me know if I missed something ^^ |
There was a problem hiding this comment.
include the code from the parent class here
There was a problem hiding this comment.
@Maks3w done. code included from the parent class, and old class removed.
|
Why not set the minimum to php 5.4? And maybe even better to 5.5 cause 5.3 is already deprecated for almost an year, and 5.4 will be soon deprecated with the release of 5.6. |
|
@HardieBoeve 5.4 will be for ZF3 //cc @weierophinney ;) |
|
ok :) .. but would it not be better for ZF3 to require at least PHP5.5? Because 5.4 is almost eol. |
|
@HardieBoeve "Adoption of PHP 5.4 and/or PHP 5.5. Right now, we want to target 5.4 |
|
@blanchonvincent thats sadly true ..... But what is the time schedule for releasing ZF3? Will it be this year? Else i personally think it will be pointless to adopt an eol version of php, because most developers are using other resources than the main resources an LTS comes with to get the latest version, but also i know some not, and yes .. when closing them out will be not an good idea. |
|
Afaik, only RHEL will be 5.4, and RHEL is designed to run ancient systems anyway (not for what is yet to be built), so 5.5 could eventually be a good candidate. I'd move this to the mailing list though. |
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
…hange/php-require-version [2.3.0] change php require version from 5.3.3 to 5.3.23 in all resources and update tests that no longer support 5.3.3
Per @weierophinney change on af3e982 at PR #5602