Codestin Search App

ojhaujjwal · 2014-02-21T07:05:23Z

I have an SQL query like this:

SELECT * FROM data da INNER JOIN device_configuration d ON d.id = da.device_id WHERE (da.device_id, da.recorded_time) IN ( SELECT device_id, MAX(recorded_time) FROM data group BY device_id ) AND d.parent_id IS NULL;

Yes, you are right, it is not supported directly by Zend Framework 2.

With this PR, you can do something like:

$select->where->in(array('column1', 'column2'), $anotherSelect);

So, the above query can be written in Zend Framework 2 as:

$maxSelect->columns(array('device_id', new SqlExpression('MAX(recorded_time)')));
$maxSelect->group('device_id'); 
$select->where->in(array('device_id', 'recorded_time'), $maxSelect);
$select->join(
    'device_configuration',
    'device_configuration.id = data.device_id'
);
$select->where->isNull('parent_id');
$resultSet = $this->select($select);

Ocramius · 2014-02-21T07:54:24Z

I have fixed this

ojhaujjwal · 2014-02-21T10:10:41Z

@Ocramius I have updated the code. I do not know why the build is failing?

samsonasik · 2014-02-21T12:58:45Z

see travis build here https://travis-ci.org/zendframework/zf2/jobs/19323397 , there is trailing_spaces need to be fixed. you can fix trailing space by php-cs-fixer and run :

php php-cs-fixer.phar fix /path/to/file.php --fixers=trailing_spaces

ojhaujjwal · 2014-02-22T01:37:28Z

@samsonasik I tried that. No luck!

samsonasik · 2014-02-22T12:34:25Z

you need to define what "No luck" is. what error you found ? have you follow the Readme ? https://github.com/fabpot/PHP-CS-Fixer/blob/master/README.rst#usage

ojhaujjwal · 2014-02-22T17:00:31Z

@samsonasik I did exactly the same command as you said. And, then I committed and it displayed that no change was detected. That is NO LUCK!

ralphschindler · 2014-02-27T21:56:07Z

This would need to change to null|string|array, and the later line needs to change to array|Select, i think

@ralphschindler Thanks for pointing out that!

ojhaujjwal · 2014-02-28T04:13:05Z

@samsonasik It was my mistake. I only run cs-fixer in In.php and forgot to run in InTest.php
Now, I did and it worked!

ralphschindler · 2014-03-05T19:37:05Z

After looking at this, I think I'd like to find a way to accomplish this without a "dynamic" specification. Primarily, this usage pattern would break the NotIn predicate.

ralphschindler · 2014-03-05T23:21:23Z

Hey @ojhaujjwal, the solution you proposed looks to have a mutually exclusive condition where when the value is select, the identifier is processed as an array. I've made a different PR that will treat the identifier and values separately when processing them for the expression data, it is located here:

https://github.com/ralphschindler/zf2/tree/feature/5854-alternative

Can you tell me if this works for you?
This also takes into account the NotIn predicate as well.

Merge branch 'feature/5854-alternative' into develop * feature/5854-alternative: Zend\Db\Sql\Predicate\In & NotIn * Changed specification so that it would work with NotIn * Modified the IN with select solution to include edge cases where the array of identifiers and select as a value are processed independent of one another. CS fixes Removed trailing spaces Update In.php CS fixes Update In.php Fixed alignment Removed trailing spaces Updated Tests of identifier array Now, identifier can also be array

ralphschindler · 2014-03-07T16:58:32Z

Merged to develop.

ojhaujjwal added 3 commits February 20, 2014 20:25

Now, identifier can also be array

5807c58

Updated Tests of identifier array

5cfad45

Removed trailing spaces

3dfaa5b

Ocramius reviewed Feb 21, 2014
View reviewed changes

ojhaujjwal added 3 commits February 21, 2014 00:00

Fixed alignment

f76f2ba

Update In.php

c31f642

CS fixes

e7e64ed

ralphschindler reviewed Feb 27, 2014
View reviewed changes

ralphschindler added this to the 2.3.0 milestone Feb 27, 2014

ralphschindler self-assigned this Feb 27, 2014

ralphschindler added the Db label Feb 27, 2014

ojhaujjwal added 3 commits February 27, 2014 19:56

Update In.php

4d502f2

Removed trailing spaces

82b2de3

CS fixes

979420b

ralphschindler closed this Mar 7, 2014

Conversation

ojhaujjwal commented Feb 21, 2014

Uh oh!

Ocramius Feb 21, 2014

Choose a reason for hiding this comment

Uh oh!

ojhaujjwal Feb 21, 2014

Choose a reason for hiding this comment

Uh oh!

ojhaujjwal commented Feb 21, 2014

Uh oh!

samsonasik commented Feb 21, 2014

Uh oh!

ojhaujjwal commented Feb 22, 2014

Uh oh!

samsonasik commented Feb 22, 2014

Uh oh!

ojhaujjwal commented Feb 22, 2014

Uh oh!

ralphschindler Feb 27, 2014

Choose a reason for hiding this comment

Uh oh!

ojhaujjwal Feb 28, 2014

Choose a reason for hiding this comment

Uh oh!

ojhaujjwal commented Feb 28, 2014

Uh oh!

ralphschindler commented Mar 5, 2014

Uh oh!

ralphschindler commented Mar 5, 2014

Uh oh!

ralphschindler commented Mar 7, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants