Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Deprecate Proxy auto-generation#5858

Merged
Maks3w merged 9 commits into
zendframework:developfrom
Ocramius:hotfix/proxy-auto-generation
Feb 26, 2014
Merged

Deprecate Proxy auto-generation#5858
Maks3w merged 9 commits into
zendframework:developfrom
Ocramius:hotfix/proxy-auto-generation

Conversation

@Ocramius
Copy link
Copy Markdown
Member

Supersedes #5198

Ping @blanchonvincent

@Ocramius Ocramius mentioned this pull request Feb 23, 2014
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be this false?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, otherwise it would fallback to the eval() logic (and not write the file to disk). I probably need to fix the test method or see if it is not redundant

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the test is redundant, as well as the config flag. Simply dropping them

@Maks3w Maks3w added this to the 2.3.0 milestone Feb 23, 2014
@Maks3w
Copy link
Copy Markdown
Member

Maks3w commented Feb 24, 2014

@Ocramius Please review the travis report. There is some problem with composer dependencies

@Ocramius
Copy link
Copy Markdown
Member Author

Saw that - cannot really fix as it seems, since it doesn't consider the dev branch of zf a 2.* (required by proxy-manager). I will diff the composer.json first

@Ocramius
Copy link
Copy Markdown
Member Author

@Maks3w yes, verified. This PR can't have green on travis because the packagist.org definitions still tell that the repository requires ocramius/proxy-manager:0.4.*.

This will get green once merged, the subtree split happened, and packagist updated its internal definitions

Maks3w added a commit that referenced this pull request Feb 26, 2014
@Maks3w Maks3w merged commit b610d96 into zendframework:develop Feb 26, 2014
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some options seems to be gone. Can you update the doc ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing that nao

@Ocramius Ocramius deleted the hotfix/proxy-auto-generation branch February 26, 2014 17:59
Ocramius added a commit to Ocramius/zf2-documentation that referenced this pull request Feb 26, 2014
gianarb pushed a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015
…fix/proxy-auto-generation

Deprecate Proxy auto-generation. Close zendframework/zendframework#5198
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants