Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

decompress() Zend/Filter/Compress/Zip fix#6026

Closed
thoys wants to merge 5 commits into
zendframework:masterfrom
thoys:master
Closed

decompress() Zend/Filter/Compress/Zip fix#6026
thoys wants to merge 5 commits into
zendframework:masterfrom
thoys:master

Conversation

@thoys
Copy link
Copy Markdown
Contributor

@thoys thoys commented Mar 22, 2014

decompress didn't work when a valid parameter was given. It relied on archive that was stored in class.
This fixes it.

@thoys
decompress() Zend/Filter/Compress/Zip fix
9e13131 
decompress didn't work when a valid parameter was given. It relied on archive that was stored in class.
This fixes it.
@thoys
Copy link
Copy Markdown
Contributor Author

thoys commented Mar 22, 2014

Hmm why does the build fail?, I didn't make a drastic change.

Maks3w
Maks3w reviewed Mar 22, 2014
View reviewed changes
Comment thread library/Zend/Filter/Compress/Zip.php Outdated
Copy link
Copy Markdown
Member

@Maks3w Maks3w Mar 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing spaces

Copy link
Copy Markdown
Contributor Author

@thoys thoys Mar 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This space already existed i just moved it, do i have to do anything to get your comment applied?

@Maks3w
Copy link
Copy Markdown
Member

Maks3w commented Mar 22, 2014

Please add a unit test

@thoys
Copy link
Copy Markdown
Contributor Author

thoys commented Mar 22, 2014

The unit test for Zip already exists, and calls this method with a param

@Maks3w
Copy link
Copy Markdown
Member

Maks3w commented Mar 22, 2014

Add a unit test showing your use case

@thoys
Copy link
Copy Markdown
Contributor Author

thoys commented Mar 22, 2014

Is this better?

@thoys
Copy link
Copy Markdown
Contributor Author

thoys commented Mar 25, 2014

Sorry, I didn't quite get the trailing spaces part till now. I hope this makes the deal.

@sjerdo
Copy link
Copy Markdown

sjerdo commented Mar 25, 2014

Go Travis, Go

@sjerdo
Copy link
Copy Markdown

sjerdo commented Mar 25, 2014

trailing spaces seems fixed in test. one of the three builds fails for a reason unknown to me

@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Mar 25, 2014

@sjerdo the cache failure is annoying - can't do much about it, it is not related with this PR.

@thoys
Copy link
Copy Markdown
Contributor Author

thoys commented Mar 31, 2014

Can anyone trigger the Travis CI to re-test this push? It should've passed.

@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Mar 31, 2014

@thoys no need to re-run travis. It was just the usual cache race condition.

@Maks3w
Copy link
Copy Markdown
Member

Maks3w commented Apr 2, 2014

Travis relunched now that tests are enabled

@Ocramius Ocramius added this to the 2.3.1 milestone Apr 2, 2014
@Ocramius Ocramius self-assigned this Apr 2, 2014
Ocramius added a commit that referenced this pull request Apr 2, 2014
@Ocramius
Adding @group and @covers annotations to zip decompress test for #…
db5db6a 
…6026
@Ocramius Ocramius closed this in 6259509 Apr 2, 2014
Ocramius added a commit that referenced this pull request Apr 2, 2014
@Ocramius
Merge branch 'hotfix/#6026-compress-filter-archive-path-fixes' into d…
0d42e03 
…evelop

Close #6026
Forward Port #6026
@Ocramius Ocramius mentioned this pull request Apr 3, 2014
Closed
gianarb pushed a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
@Ocramius
Adding @group and @covers annotations to zip decompress test for z…
8ba3b2d 
…endframework/zendframework#6026
gianarb pushed a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6026-compress-filter…
79a0d3d 
…-archive-path-fixes'

Close zendframework/zendframework#6026
gianarb pushed a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
@Ocramius
Merge branch 'hotfix/zendframework/zendframework#6026-compress-filter…
aec4d8f 
…-archive-path-fixes' into develop

Close zendframework/zendframework#6026
Forward Port zendframework/zendframework#6026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@Ocramius Ocramius

Labels

bug Filter

Projects

None yet

Milestone

2.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@thoys @Maks3w @sjerdo @Ocramius