Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Lots of PHPCS fixes#6454

Closed
chadicus wants to merge 48 commits into
zendframework:masterfrom
chadicus:phpcs
Closed

Lots of PHPCS fixes#6454
chadicus wants to merge 48 commits into
zendframework:masterfrom
chadicus:phpcs

Conversation

@chadicus
Copy link
Copy Markdown
Contributor

Got bored this weekend, decided to start fixing PHPCS errors on top of @localheinz pull request #6182

@localheinz
Copy link
Copy Markdown
Member

@chadicus

Not bad!

Maybe these CS fixes should be merged back into the branch off of which they are based?

@localheinz
Copy link
Copy Markdown
Member

@chadicus

I made some fixes in #6182, maybe you'd like to rebase?

  • Travis complains because the log is too big, so I adjusted the command run on Travis to show the summary report only.
  • Also, I reverted the removal of the suggestion to create a Git pre-commit hook and adjusted the existing one to use phpcs with the full report

Showing the summary report on Travis for now is probably better because there are so many issues, we could switch back to the full report later.

@localheinz
Copy link
Copy Markdown
Member

@chadicus

Also, as somehow suggested here maybe it's easier for someone to review if there'd be one PR per namespace (i.e., component) only?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could have been fixed without relying on a local variable.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@chadicus
Copy link
Copy Markdown
Contributor Author

Rebased off of zend/master Separated by Zend/X namespace per commit

@chadicus
Copy link
Copy Markdown
Contributor Author

There were 4 classes that I had to move methods in order for php-cs-fixer to work. I'm assuming each had some character(s) in them that was throwing off the tokenizer. php-cs-fixer tried to do some odd things such as in \Zend\Di\Di.php In order to pass the fixer wanted protected function getClass($instance) to be protected function getClass(public $instance) Instead of making this obvious syntax change. I simply moved the method within the class.

@chadicus chadicus closed this Jul 14, 2014
@chadicus chadicus deleted the phpcs branch July 14, 2014 21:25
@chadicus chadicus restored the phpcs branch July 15, 2014 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants