Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

PHPCS Fixes for Zend\Authentication#6459

Closed
chadicus wants to merge 1 commit into
zendframework:masterfrom
chadicus:phpcs-authentication
Closed

PHPCS Fixes for Zend\Authentication#6459
chadicus wants to merge 1 commit into
zendframework:masterfrom
chadicus:phpcs-authentication

Conversation

@chadicus
Copy link
Copy Markdown
Contributor

@chadicus chadicus commented Jul 14, 2014

Taking @localheinz suggestion and putting in smaller pull requests per component.

@chadicus chadicus closed this Jul 14, 2014
@chadicus chadicus deleted the phpcs-authentication branch July 14, 2014 21:34
@localheinz
Copy link
Copy Markdown
Member

localheinz commented Jul 15, 2014

@chadicus

If you like, I can help you with this!

@chadicus
Copy link
Copy Markdown
Contributor Author

chadicus commented Jul 15, 2014

I can't figure out why the unit tests are failing. I figured I'd close the PRs for now until i can find the time to work on it.

@localheinz any help would be greatly appreciated. I have two issues with the pull request.

First, there are some odd visibility and indentation cs issues that php-cs-fixer finds, however there is no actual issue. Those are found in

   1) Zend/Di/Di.php (visibility)
   2) Zend/Cache/Storage/Adapter/RedisResourceManager.php (visibility)
   3) Zend/Cache/Storage/Adapter/MemcachedResourceManager.php (visibility)
   4) Zend/Json/Decoder.php (visibility)
   5) ZendTest/Tag/Cloud/Decorator/HtmlTagTest.php (indentation)

These issues are found with a fresh checkout of zend/master

The second issue are 3 unit tests that fail with mismatched dates. They only seem to fail on PHP 5.6, however I have 5.5 locally and have not had a chance to set up a 5.6 environment in order to check them.

ZendTest\Feed\Reader\Entry\AtomTest::testGetsDateCreatedWithFractional
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
 DateTime Object (
-    'date' => '2009-03-07 08:03:50.000000'
+    'date' => '2009-03-07 08:03:50.800000'
     'timezone_type' => 2
     'timezone' => 'Z'
 )
/home/travis/build/zendframework/zf2/tests/ZendTest/Feed/Reader/Entry/AtomTest.php:115

ZendTest\Feed\Reader\Entry\AtomTest::testGetsDateModifiedWithFractional
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
 DateTime Object (
-    'date' => '2009-03-07 08:03:50.000000'
+    'date' => '2009-03-07 08:03:50.800000'
     'timezone_type' => 2
     'timezone' => 'Z'
 )
/home/travis/build/zendframework/zf2/tests/ZendTest/Feed/Reader/Entry/AtomTest.php:148

ZendTest\Ldap\Converter\ConverterTest::testToLdapSerialize with data set #2 ('O:8:"DateTime":3:{s:4:"date";s:19:"1970-01-01 00:00:00";s:13:"timezone_type";i:1;s:8:"timezone";s:6:"+00:00";}', DateTime)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'O:8:"DateTime":3:{s:4:"date";s:19:"1970-01-01 00:00:00";s:13:"timezone_type";i:1;s:8:"timezone";s:6:"+00:00";}'
+'O:8:"DateTime":3:{s:4:"date";s:26:"1970-01-01 00:00:00.000000";s:13:"timezone_type";i:1;s:8:"timezone";s:6:"+00:00";}'
/home/travis/build/zendframework/zf2/tests/ZendTest/Ldap/Converter/ConverterTest.php:104

@chadicus chadicus restored the phpcs-authentication branch July 15, 2014 12:16
@chadicus
Copy link
Copy Markdown
Contributor Author

chadicus commented Jul 15, 2014

I've opened a smaller pull request #6462 to resolve these odd phpcs issues.

@chadicus chadicus deleted the phpcs-authentication branch December 11, 2014 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chadicus @localheinz