This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Changing encode from View Helper is not passed to EscapeHtmlAttrHelper#6707
Closed
stephandesouza wants to merge 4 commits into
Closed
Changing encode from View Helper is not passed to EscapeHtmlAttrHelper#6707stephandesouza wants to merge 4 commits into
stephandesouza wants to merge 4 commits into
Conversation
Ideal where using ZF2 on non UTF-8 encoded projects. Sample: - http://pastebin.com/8uZHm5BM - http://pastebin.com/pwjQdFe9
Member
This would be good. |
Member
|
Actually requires test cases. Escaping and encoding are security-sensitive areas that should not be taken lightly at any time. |
Contributor
Author
|
Consider it done @Ocramius |
Member
|
@stephandesouza can you remove commit stephandesouza/zf2@94eaa30? You should never ever merge target branches into the feature/hotfix branches: rebase instead. Otherwise I can cherry-pick it myself |
Contributor
Author
|
Is not nice to work sleepy, ignore this PR. :( |
Member
|
@stephandesouza thanks for the new PR :-) |
Member
|
Marking as duplicate of #7002 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideal where using ZF2 Components on non UTF-8 encoded projects (like onto ISO-8859-1 files), because this throws a Fatal Error at Zend/Escaper/Escaper.php on line 325.
Sample
Will add a Test if needed
Stack Trace