Symfony 5 support#31
Merged
Merged
Conversation
weaverryan
reviewed
Aug 26, 2020
weaverryan
left a comment
There was a problem hiding this comment.
Happy to see the PR - we will need it very soon :)
Member
|
Thanks @napestershine, don't worry about the failing travis build - it's a known issue I need to look into. @weaverryan should we keep Symfony 3.4 support? |
Member
|
Never mind, I see Ryan suggested only supporting 4.4+. I'm good with that. @napestershine, can you change the symfony package constraints from |
Contributor
Author
|
@kbond I have updated it. |
Member
|
Thanks, tagged v3.4.0. |
Contributor
Author
|
@kbond I am getting exact same errors on my installation shown by Travis. |
Member
|
I see a lot of different travis errors - can you link to the specific one? |
Member
|
@napestershine, I refactored and got the CI tests working again - can you try v3.5.0? |
Contributor
Author
|
Yes sure. I will try it and update you. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.