feat(sqlx): add field tag (-) skip logic in unwrapFields
#5010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your contribution! Please add unit tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Contributor
Author
Thanks! I've added unit tests. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for skipping struct fields during SQL unmarshaling by introducing field tag (-) skip logic in the unwrapFields function. This allows developers to exclude specific struct fields from database mapping operations.
- Adds field skipping logic using
db:"-"tag in theunwrapFieldsfunction - Implements comprehensive test coverage for both single row and multiple rows scenarios with ignored fields
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/stores/sqlx/orm.go | Adds skip logic to check for - tag and continue to next field if found |
| core/stores/sqlx/orm_test.go | Adds test cases validating field skipping behavior for both unmarshalRow and unmarshalRows functions |
Comments suppressed due to low confidence (2)
core/stores/sqlx/orm_test.go:1036
- [nitpick] The variable name 'expect' should be renamed to 'expected' or 'expectedValues' to be more descriptive and follow Go naming conventions.
expect := []struct {
core/stores/sqlx/orm_test.go:1080
- [nitpick] The variable name 'each' should be renamed to something more descriptive like 'expectedItem' or 'expectedValue' to improve code readability.
for i, each := range expect {
kevwan
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.