fix: resolve concurrent get may lead to empty result in ImmutableResource #5065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a concurrency issue in ImmutableResource.Get() where multiple goroutines could receive (nil, nil) results when accessing the resource simultaneously. The fix simplifies the synchronization logic by removing the separate maybeRefresh function and using a single write lock to ensure thread-safe resource initialization.
- Replaces complex dual-lock pattern with simpler single write lock approach
- Adds comprehensive concurrent access test to verify the fix
- Removes unused
refreshLockfield andmaybeRefreshmethod
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/syncx/immutableresource.go | Simplifies concurrency control by using single write lock and removing maybeRefresh function |
| core/syncx/immutableresource_test.go | Adds concurrent access test to verify thread safety with 100 goroutines |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…urce.Get() method
Co-authored-by: Copilot <[email protected]>
ea90f4b to
a95daf8
Compare
kevwan
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Problem
Concurrent calls to
ImmutableResource.Get()could return(nil, nil)when:resource == nilsimultaneouslymaybeRefreshcheck