optimize: logging with fields #5066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes logging with fields by deferring field value processing until the actual log output, preventing unnecessary computation when logs are filtered out by level. The change moves field value type conversion and formatting from the Field() function to the output() function.
- Moved field value processing from
Field()creation tooutput()execution - Added comprehensive test coverage for log level filtering with field processing
- Introduced deferred evaluation to avoid processing fields when logs won't be written
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/logx/writer.go | Added processFieldValue function and integrated it into output() for deferred field processing |
| core/logx/logs.go | Simplified Field() function to store raw values without immediate processing |
| core/logx/logs_test.go | Added tests to verify field processing is skipped when log level filtering occurs |
zhoushuguang
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.