(goctl)feature: supported sse generation #5082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tools/goctl/api/gogen/genroutes.go
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
kevwan
approved these changes
Aug 12, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Server-Sent Events (SSE) generation support to the goctl tool, allowing automatic generation of SSE-specific handlers and logic templates. The feature introduces conditional template selection based on the "sse" annotation in API specifications.
- Adds SSE-specific templates for handlers and logic components
- Implements conditional logic to generate different code paths for SSE vs standard HTTP handlers
- Updates version to 1.8.6-alpha and fixes a typo in version tags
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| analyzer.go | Adds validation to ensure SSE routes have response types |
| version.go | Updates version to 1.8.6-alpha and fixes "pre-bata" typo |
| template.go | Registers new SSE template files |
| sse_logic.tpl | Template for SSE logic components with channel-based responses |
| sse_handler.tpl | Template for SSE handlers with event streaming logic |
| genlogic.go | Adds conditional SSE logic generation with modified signatures |
| genhandlers.go | Implements SSE handler generation with template selection |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
kevwan
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.