feat: support goctl --module to set go module #5135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying custom Go module names when generating services with goctl. The feature is controlled by a new --module flag that allows users to set a custom module name instead of defaulting to the directory name.
- Introduces
PrepareWithModuleandGetParentPackageWithModulefunctions to handle custom module names - Adds
--moduleflag support to both API and RPC generation commands - Updates generators to use custom module names when creating go.mod files
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/goctl/util/ctx/context.go | Adds PrepareWithModule function to support custom module initialization |
| tools/goctl/util/ctx/context_test.go | Comprehensive tests for module functionality including edge cases |
| tools/goctl/pkg/golang/path.go | Adds GetParentPackageWithModule with custom module support |
| tools/goctl/pkg/golang/path_test.go | Tests for module-aware package path resolution |
| tools/goctl/rpc/generator/gen.go | Integrates module support into RPC generation |
| tools/goctl/rpc/generator/gen_module_test.go | Tests RPC generation with custom modules |
| tools/goctl/rpc/cli/*.go | Adds --module flag to RPC command interface |
| tools/goctl/api/gogen/gen.go | Adds DoGenProjectWithModule for API generation with custom modules |
| tools/goctl/api/new/*.go | Integrates module support into API service creation |
| tools/goctl/internal/flags/default_en.json | Adds help text for new --module flag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.