New writer API, batch body adding bindings #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kcbanner
commented
Sep 11, 2025
- Add AddBodiesAbort / AddBodiesFinalize / AddBodiesPrepare
- Update the reader / writer to the new API
- Update the reader / writer to the new API
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Zig physics library to support a new batch body adding API and modernizes I/O handling. The changes introduce a three-phase body addition system (Prepare/Finalize/Abort) for better performance when adding multiple bodies at once, and update the library to use newer Zig I/O APIs.
- Adds new batch body operations:
AddBodiesAbort,AddBodiesFinalize, andAddBodiesPrepare - Updates I/O handling from deprecated
AnyWriter/AnyReaderAPIs to modernstd.Io.Writer/std.Io.Reader - Modernizes ArrayList initialization patterns and argument ordering
- Updates minimum Zig version requirement to 0.15.1
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/zphysics.zig | Main implementation changes including new batch API bindings, I/O modernization, and test updates |
| libs/JoltC/JoltPhysicsC.h | C header additions for new batch body interface functions |
| libs/JoltC/JoltPhysicsC.cpp | C++ implementation of the new batch body operations |
| build.zig.zon | Updates minimum Zig version requirement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.