Reduce log verbosity in zigpy.topology route/neighbor scan #1657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Successful topology scan can create a significant log noise printing all neighbors and routes with INFO verbosity. As it's not expected the details will be needed when casually checking the logs, lower these log messages to DEBUG verbosity.
There was a problem hiding this comment.
Pull Request Overview
This PR reduces log verbosity for topology scanning operations by changing successful neighbor and route scan messages from INFO to DEBUG level. The purpose is to minimize log noise during routine topology scans while preserving detailed information for debugging when needed.
- Reduced log level for successful neighbor scan results from INFO to DEBUG
- Reduced log level for successful route scan results from INFO to DEBUG
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1657 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 57 57
Lines 11638 11638
=======================================
Hits 11556 11556
Misses 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful topology scan can create a significant log noise printing all neighbors and routes with INFO verbosity. As it's not expected the details will be needed when casually checking the logs, lower these log messages to DEBUG verbosity.