Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Green Power Clusters and supporting Schemas #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
puddly merged 8 commits into from
Sep 11, 2025
Merged

Green Power Clusters and supporting Schemas #1659

puddly merged 8 commits into from
Sep 11, 2025

Conversation

@konistehrad
Copy link
Contributor

@konistehrad konistehrad commented Aug 28, 2025 •
edited
Loading

Adds green power clusters to the ZCL, including a mess of supporting CommandSchemas and Schemas.

Organizational changes from original PR:

  • Remove GP prefix, preferring instead using module-level scoping
  • Split Struct types into types.py, leave CommandSchema types in greenpower.py

Questions:

  • For unit tests, should I be parsing known-good ZGP frames for commands? Or since these are just structs basically, are we good for unit tests on this one?

Thanks everyone for your patience, and of course @puddly for your help!

@konistehrad konistehrad reopened this Aug 28, 2025
@codecov
Copy link

codecov bot commented Aug 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.31%. Comparing base (88f0ae1) to head (ae96171).
⚠️ Report is 5 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1659      +/-   ##
==========================================
+ Coverage   99.29%   99.31%   +0.01%     
==========================================
  Files          57       62       +5     
  Lines       11657    12043     +386     
==========================================
+ Hits        11575    11960     +385     
- Misses         82       83       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ulope ulope mentioned this pull request Aug 30, 2025
Closed
@konistehrad konistehrad marked this pull request as ready for review August 31, 2025 17:27
konistehrad
konistehrad commented Aug 31, 2025
View reviewed changes
konistehrad
konistehrad commented Aug 31, 2025
View reviewed changes
@konistehrad
Copy link
Contributor Author

konistehrad commented Aug 31, 2025

OK cool thanks for bearing with me as I get back into the project. I think this is ready to go barring the questions above.

puddly
puddly reviewed Sep 8, 2025
View reviewed changes
@konistehrad
Copy link
Contributor Author

konistehrad commented Sep 9, 2025

All comments resolved, thanks!

puddly
puddly reviewed Sep 10, 2025
View reviewed changes
@puddly puddly merged commit b319f45 into zigpy:dev Sep 11, 2025
14 checks passed
@Hedda Hedda mentioned this pull request Oct 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@puddly puddly puddly left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@konistehrad @puddly