Load devices by default when performing a backup #1666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request changes the default behavior of the create_backup method to always load device information during backup operations. The change addresses compatibility issues with older Aqara devices on EZSP networks by ensuring an up-to-date child table is included in backups.
- Changes the default value of
load_devicesparameter fromFalsetoTruein thecreate_backupmethod
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1666 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 57 57
Lines 11657 11657
=======================================
Hits 11575 11575
Misses 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backup/restore for EZSP requires an up-to-date child table for the network to work properly with older Aqara devices. For this reason, we should always perform a complete backup/restore.
This is a minor change but has two side effects: