Remove incorrect direction warning
#1697
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR demotes a warning message about incorrectly directed cluster messages to a debug-level log, as sufficient reports have been collected to address the underlying quirks in real-world devices. The warning is no longer needed for user-facing diagnostics.
Key changes:
- Changed log level from
warningtodebugfor incorrect cluster direction messages - Removed the associated test case that validated the warning behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| zigpy/device.py | Downgraded logging level from LOGGER.warning to LOGGER.debug for incorrect cluster direction messages |
| tests/test_device.py | Removed test case test_device_flipped_cluster_warning and cleaned up unused OnOff import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheJulianJES
left a comment
There was a problem hiding this comment.
Agreed.
Since we keep the message at debug level, doesn't it also make sense to keep the test? Or is this so trivial we just don't want the test for that?
|
We don't test any other debug logging so I just thought it wasn't worth the extra code. |
|
Yeah, ok. We don't really have any explicit tests for the matching/flipping logic then, right? At least none were added with https://github.com/zigpy/zigpy/pull/1639/files, other than the one that mainly checks for the warning to be present. |
|
Ooo, good point. I'll see about adding one. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1697 +/- ##
=======================================
Coverage 99.30% 99.30%
=======================================
Files 63 63
Lines 12188 12188
=======================================
Hits 12103 12103
Misses 85 85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We've collected enough reports in #1640 to fix all of the quirks and to get a good idea of how many real-world devices do this poorly.