fix: make cli skip private packages without version field#720
fix: make cli skip private packages without version field#720Andarist merged 4 commits intochangesets:mainfrom bhovhannes:main-hb-skip-private-packages
Conversation
🦋 Changeset detectedLatest commit: ede6c65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ede6c65:
|
|
@Andarist I'll be grateful for you review. I believe this does not contradict with #705 . I am not sure which type of tests to write to this change and where, as the change affects what CLI is showing, which is mocked in existing tests I've looked at. I can spend more time on tests once we'll be settled with implementation. |
|
@Andarist do you have any comments here or this can be merged? |
|
@Andarist friendly ping. Can this be merged or something else needs to be done first ? |
|
@bhovhannes thanks for the ping and sorry for going MIA on this one. I have a couple of things to check in relation to private packages and I would like to land this after I investigate all of them, so my decision can take all of the gathered information into account. For the time being, I think this is OK to go but IIRC somebody has raised concerns that such packages might not be "linkable" in some monorepo setups and I need to check this out. It seems though that you have rebased this PR in a way that I see now some stuff that shouldn't be here. If you could clean this up - I would highly appreciate it. |
I see. Let me know if something will be needed from my side. I plan to migrate one of my monorepos to changesets (pnpm + changesets + turborepo combo) and my monorepo contains private packages without version field, so I'll pay attention to that.
rebased again and squashed all my commits into one |
This closes #620
Per conversation there, it was decided to skip packages without "version" field in CLI. I limited that to private packages without "version" field to limit the blast radius of this behavior change.