feat: Show plugin version in plugin server logs (#2124)

disq · web-flow · commit be08606413a4 · 2025-04-22T16:19:09.000Z
This could make certain things easier to debug.
diff --git a/plugin/plugin.go b/plugin/plugin.go
@@ -166,6 +166,10 @@ func (p *Plugin) Meta() Meta {
 	}
 }
 
+func (p *Plugin) PackageAndVersion() string {
+	return fmt.Sprintf("%s/%s/%s@%s", p.team, p.kind, p.name, p.version)
+}
+
 // SetSkipUsageClient sets whether the usage client should be skipped
 func (p *Plugin) SetSkipUsageClient(v bool) {
 	p.skipUsageClient = v
diff --git a/serve/info.go b/serve/info.go
@@ -1,8 +1,6 @@
 package serve
 
 import (
-	"fmt"
-
 	"github.com/spf13/cobra"
 )
 
@@ -18,7 +16,7 @@ func (s *PluginServe) newCmdPluginInfo() *cobra.Command {
 		Long:  pluginInfoLong,
 		Args:  cobra.ExactArgs(0),
 		RunE: func(cmd *cobra.Command, _ []string) error {
-			cmd.Println(fmt.Sprintf("Package and version: %s/%s/%s@%s", s.plugin.Team(), s.plugin.Kind(), s.plugin.Name(), s.plugin.Version()))
+			cmd.Println("Package and version:", s.plugin.PackageAndVersion())
 			return nil
 		},
 	}
diff --git a/serve/plugin.go b/serve/plugin.go
@@ -222,7 +222,7 @@ func (s *PluginServe) newCmdPluginServe() *cobra.Command {
 				}
 			}()
 
-			logger.Info().Str("address", listener.Addr().String()).Msg("Plugin server listening")
+			logger.Info().Str("address", listener.Addr().String()).Str("plugin", s.plugin.PackageAndVersion()).Msg("Plugin server listening")
 			if err := grpcServer.Serve(listener); err != nil {
 				return fmt.Errorf("failed to serve: %w", err)
 			}

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,10 @@ func (p *Plugin) Meta() Meta {`
`166`	`166`	`}`
`167`	`167`	`}`
`168`	`168`
	`169`	`+func (p *Plugin) PackageAndVersion() string {`
	`170`	`+ return fmt.Sprintf("%s/%s/%s@%s", p.team, p.kind, p.name, p.version)`
	`171`	`+}`
	`172`	`+`
`169`	`173`	`// SetSkipUsageClient sets whether the usage client should be skipped`
`170`	`174`	`func (p *Plugin) SetSkipUsageClient(v bool) {`
`171`	`175`	`p.skipUsageClient = v`
Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ func (s PluginServe) newCmdPluginServe() cobra.Command {`
`222`	`222`	`}`
`223`	`223`	`}()`
`224`	`224`
`225`		`- logger.Info().Str("address", listener.Addr().String()).Msg("Plugin server listening")`
	`225`	`+ logger.Info().Str("address", listener.Addr().String()).Str("plugin", s.plugin.PackageAndVersion()).Msg("Plugin server listening")`
`226`	`226`	`if err := grpcServer.Serve(listener); err != nil {`
`227`	`227`	`return fmt.Errorf("failed to serve: %w", err)`
`228`	`228`	`}`