fix(core): Improve safeJoin usage in console logging integration#16658
Merged
AbhiPrasad merged 1 commit intodevelopfrom Jun 20, 2025
Merged
fix(core): Improve safeJoin usage in console logging integration#16658AbhiPrasad merged 1 commit intodevelopfrom
safeJoin usage in console logging integration#16658AbhiPrasad merged 1 commit intodevelopfrom
Conversation
andreiborza
approved these changes
Jun 20, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #16657
Background
In the
consoleLoggingIntegration(which sends logs to Sentry from console calls), we use a utility calledsafeJointo join together the console args.sentry-javascript/packages/core/src/utils/string.ts
Lines 68 to 94 in b94f652
This utility calls
String(value)to convert items to a string, which results in objects and arrays being turned into the dreaded[Object Object]or[Array].sentry-javascript/packages/core/src/utils/string.ts
Line 86 in b94f652
A user wrote in with feedback that this was annoying, and I agree!
Solution
Instead of using
String(value)I chose to create a new helper that usesJSON.stringify(normalize(X)), which should result in the entire object or array being properly shown. This required me to grabnormalizeDepthandnormalizeMaxBreadthfrom the client options, but that feels fine because it's easily explainable to users.I added tests to validate this.
Next Steps
We should really refactor our overall
safeJoinusage. This should be safe in breadcrumbs, but will be a breaking change incapture-consoleas it'll cause issue grouping changes if console calls are being captured as messages/errors.