fix(v10/sveltekit): Read SvelteKit config from the Vite plugin - #23998
Merged
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e8dcd3e. Configure here.
chargome
marked this pull request as ready for review
September 3, 2026 12:17
chargome
requested review from
a team,
Lms24,
mydea and
s1gr1d
and removed request for
a team
September 3, 2026 12:17
Lms24
approved these changes
Sep 3, 2026
chargome
deleted the
backport-v10/23678-read-kit-config-from-vite-plugin
branch
September 3, 2026 12:29
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #23678
Differences to the original PR
src/vite/sentryVitePlugins.ts: dropped thewarnOnRemovedBuildOptions(options, ['unstable_sentryVitePluginOptions'])call. That line is pre-existing context ondevelopfrom feat(sveltekit)!: Remove unstable_sentryVitePluginOptions #23366, which removed the option in v11 — v10 still supports it, andwarnOnRemovedBuildOptionsisn't exported from v10's@sentry/core.src/vite/sentryVitePlugins.ts(generateVitePluginOptions): kept v10's deprecatedsourceMapsUploadOptions/unstable_sentryVitePluginOptionsmerging untouched. Only this PR's actual change was applied —adapteris now destructured out of the options handed to the Vite plugin and the explicitadapter: svelteKitPluginOptions.adapterwas dropped. The placeholder is_filtered5rather than_filtered3because v10 filters two extra deprecated options.test/vite/sentrySvelteKitPlugins.test.ts: plugin-count expectations are v10's counts plus one for the new kit config resolver (8/3/4/7), notdevelop's (9/4/5/8). v10 has no orchestrion Vite plugin — that's feat(sveltekit): Auto-wire orchestrion build-time instrumentation #22768, v11-only.