Thanks to visit codestin.com
Credit goes to github.com

Skip to content

registry: add cargo-release#10258

Merged
jdx merged 1 commit into
mainfrom
registry/add-cargo-release
Jun 6, 2026
Merged

registry: add cargo-release#10258
jdx merged 1 commit into
mainfrom
registry/add-cargo-release

Conversation

@jdx

@jdx jdx commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • add cargo-release registry shorthand backed by github:crate-ci/cargo-release
  • include a cargo release --version smoke test

Popularity

  • GitHub: 1,564 stars, 132 forks
  • Latest release: v1.1.2 published 2026-03-24
  • Recent activity: pushed 2026-06-04

Test

  • cargo build --all-features
  • target/debug/mise test-tool cargo-release

This PR was generated by an AI coding assistant.


Note

Cursor Bugbot is generating a summary for commit 49fb071. Configure here.

Summary by CodeRabbit

  • Chores
    • Expanded registry with new cargo-release entry, including automated test validation to ensure proper version reporting.

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

A new registry configuration file for the cargo-release Cargo subcommand is added, defining the GitHub backend source (crate-ci/cargo-release), a description, and a validation test that confirms cargo release --version outputs the expected version string pattern.

Changes

Cargo-release registry entry

Layer / File(s) Summary
Cargo-release registry configuration
registry/cargo-release.toml
Registry entry for cargo-release Cargo subcommand defines the github:crate-ci/cargo-release backend, description, and a cargo release --version test assertion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A registry grows, one entry at a time,
Cargo-release joins the line,
With backends and tests set fine,
The wheel turns—⚙️ all is aligned! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'registry: add cargo-release' accurately and concisely summarizes the main change: adding a new cargo-release entry to the registry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch registry/add-cargo-release

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a registry shorthand for cargo-release (the crate-ci/cargo-release Cargo release automation tool) with a smoke test that verifies the installed version.

  • Single github:crate-ci/cargo-release backend is registered; the description and test format are consistent with existing registry entries.
  • Unlike every other cargo-* registry entry (cargo-binstall, cargo-dist, cargo-insta, cargo-make), no cargo:cargo-release backend is listed — the crate is published to crates.io and would be a natural fallback.

Confidence Score: 4/5

Safe to merge; the entry is structurally correct and follows existing conventions. The only gap is the missing cargo: backend that all peer entries carry.

The file follows the established registry format — description, github: backend, and a version smoke test — and is consistent with how other tools in the registry are defined. The sole observation is that every other cargo-* entry lists a cargo: fallback backend, and this one does not despite the crate being published to crates.io.

registry/cargo-release.toml — missing cargo: backend worth adding before merge

Important Files Changed

Filename Overview
registry/cargo-release.toml New registry entry for cargo-release backed by github:crate-ci/cargo-release; missing cargo: backend that all other cargo-* registry entries include

Fix All in Claude Code

Reviews (1): Last reviewed commit: "registry: add cargo-release" | Re-trigger Greptile

@@ -0,0 +1,3 @@
backends = ["github:crate-ci/cargo-release"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Every other cargo-* registry entry (cargo-binstall, cargo-dist, cargo-insta, cargo-make) includes a cargo: backend alongside the primary one. cargo-release is published to crates.io, so omitting it leaves users who can't reach GitHub release assets without a fallback.

Suggested change
backends = ["github:crate-ci/cargo-release"]
backends = ["github:crate-ci/cargo-release", "cargo:cargo-release"]

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@registry/cargo-release.toml`:
- Line 3: The test currently runs "cargo release --version" which invokes the
system "cargo" binary instead of the installed tool; update the test
configuration so test.cmd uses the installed binary name "cargo-release
--version" (keeping expected = "cargo-release {{version}}") to ensure the runner
executes the installed cargo-release binary rather than the top-level cargo
command.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 42472250-1c30-42b8-8774-bf91a567b5ba

📥 Commits

Reviewing files that changed from the base of the PR and between d579146 and 49fb071.

📒 Files selected for processing (1)
  • registry/cargo-release.toml

@@ -0,0 +1,3 @@
backends = ["github:crate-ci/cargo-release"]
description = "Cargo subcommand for releasing crates"
test = { cmd = "cargo release --version", expected = "cargo-release {{version}}" }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use the installed binary name in test.cmd to avoid false negatives.

The runner resolves/execut es only the first token of cmd; using cargo release --version makes the test hinge on a cargo binary being present, not strictly on the installed cargo-release tool. This can fail even when cargo-release is correctly installed.

Suggested fix
-test = { cmd = "cargo release --version", expected = "cargo-release {{version}}" }
+test = { cmd = "cargo-release --version", expected = "cargo-release {{version}}" }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
test = { cmd = "cargo release --version", expected = "cargo-release {{version}}" }
test = { cmd = "cargo-release --version", expected = "cargo-release {{version}}" }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@registry/cargo-release.toml` at line 3, The test currently runs "cargo
release --version" which invokes the system "cargo" binary instead of the
installed tool; update the test configuration so test.cmd uses the installed
binary name "cargo-release --version" (keeping expected = "cargo-release
{{version}}") to ensure the runner executes the installed cargo-release binary
rather than the top-level cargo command.

@jdx jdx enabled auto-merge (squash) June 6, 2026 23:40
@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.0 x -- echo 20.8 ± 1.6 17.7 28.1 1.00
mise x -- echo 21.2 ± 1.8 18.1 31.3 1.02 ± 0.12

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.0 env 20.3 ± 1.5 17.8 26.0 1.00
mise env 20.9 ± 1.7 17.9 26.5 1.03 ± 0.11

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.0 hook-env 21.0 ± 1.5 18.1 26.1 1.00
mise hook-env 21.4 ± 1.7 18.5 30.2 1.02 ± 0.11

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.0 ls 17.1 ± 1.4 14.2 21.8 1.00
mise ls 17.7 ± 1.7 14.7 24.5 1.04 ± 0.13

xtasks/test/perf

Command mise-2026.6.0 mise Variance
install (cached) 145ms 147ms -1%
ls (cached) 67ms 64ms +4%
bin-paths (cached) 71ms 73ms -2%
task-ls (cached) 139ms 139ms +0%

@jdx jdx merged commit 727446d into main Jun 6, 2026
35 checks passed
@jdx jdx deleted the registry/add-cargo-release branch June 6, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant