fix: adjust add-on option types#692
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 0581edc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
AdrianGonz97
commented
Sep 5, 2025
AdrianGonz97
commented
Sep 5, 2025
AdrianGonz97
commented
Sep 5, 2025
jycouet
reviewed
Sep 5, 2025
Contributor
jycouet
left a comment
There was a problem hiding this comment.
Thank you for this follow up.
I think that we can also revert the typedEntries in packages/addons/tailwindcss/index.ts and bring back the array of plugin (similar to packages/addons/sveltekit-adapter/index.ts ?
May I do it in this branch ? or ?
Member
Author
go for it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed some spots that could be improved from #686. Mainly lessening the need to use
as constat the builder's usage site, prettifying the resulting option type by flattening it, and other minor tweaks.