-
-
Notifications
You must be signed in to change notification settings - Fork 55
fix: adjust add-on option types #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0581edc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this follow up.
I think that we can also revert the typedEntries
in packages/addons/tailwindcss/index.ts
and bring back the array of plugin (similar to packages/addons/sveltekit-adapter/index.ts
?
May I do it in this branch ? or ?
go for it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me 🚀
Thx
Noticed some spots that could be improved from #686. Mainly lessening the need to use
as const
at the builder's usage site, prettifying the resulting option type by flattening it, and other minor tweaks.