Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

AdrianGonz97
Copy link
Member

Noticed some spots that could be improved from #686. Mainly lessening the need to use as const at the builder's usage site, prettifying the resulting option type by flattening it, and other minor tweaks.

Copy link

changeset-bot bot commented Sep 5, 2025

🦋 Changeset detected

Latest commit: 0581edc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AdrianGonz97 AdrianGonz97 requested a review from jycouet September 5, 2025 18:33
Copy link

pkg-pr-new bot commented Sep 5, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@692
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@692

commit: 0581edc

Copy link
Contributor

@jycouet jycouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this follow up.

I think that we can also revert the typedEntries in packages/addons/tailwindcss/index.ts and bring back the array of plugin (similar to packages/addons/sveltekit-adapter/index.ts ?

May I do it in this branch ? or ?

@AdrianGonz97
Copy link
Member Author

May I do it in this branch ? or ?

go for it!

Copy link
Contributor

@jycouet jycouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 🚀
Thx

@AdrianGonz97 AdrianGonz97 merged commit e4a5ac2 into main Sep 5, 2025
8 checks passed
@AdrianGonz97 AdrianGonz97 deleted the fix/tweak-add-on-option-types branch September 5, 2025 19:41
@github-actions github-actions bot mentioned this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants