fix: only merge plain objects #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 79 92 +13
Branches 24 28 +4
=========================================
+ Hits 79 92 +13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #100
β Type of change
π Description
When merging two objects, we were not checking if two objects are not pure object and also using
Object.assignto merge even classes, which can lead to unwanted behavior such as merging twoDatevalues.This PR fixes this issue by adding little bit of overhead to the checks using a fork of is-plain-obj
π Checklist