Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: handle uvx like uv#920

Merged
henryiii merged 1 commit into
wntrblm:mainfrom
henryiii:henryiii/fix/uvx
Jan 31, 2025
Merged

fix: handle uvx like uv#920
henryiii merged 1 commit into
wntrblm:mainfrom
henryiii:henryiii/fix/uvx

Conversation

@henryiii

@henryiii henryiii commented Jan 31, 2025

Copy link
Copy Markdown
Collaborator

edgarrmondragon
edgarrmondragon reviewed Jan 31, 2025
View reviewed changes

@edgarrmondragon edgarrmondragon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing the warning

nox > Warning: uvx is not installed into the virtualenv, it is located at /Users/me/.local/bin/uvx. This might cause issues! Pass external=True into run() to silence this message.

I used uvx --with git+https://github.com/wntrblm/nox.git@refs/pull/920/head nox -rs <session>

PS: I also had to change nox.options.sessions to be a list since it was erroring with a tuple, so we should call it out in the future release notes.

@henryiii

henryiii commented Jan 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Oops, I thought about that when I started, but forgot about it by the time I added a test. I'll add it. Though I don't remember where we handle this for "uv".

@henryiii

henryiii commented Jan 31, 2025

Copy link
Copy Markdown
Collaborator Author

Where was nox.options.sessions a tuple?

@edgarrmondragon

edgarrmondragon commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

Where was nox.options.sessions a tuple?

In my noxfile.py. I see the examples in https://nox.thea.codes/en/stable/config.html all use lists, so maybe only I was in the wrong 😅

@henryiii
fix: handle uvx like uv
6aff5c2 
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii

henryiii commented Jan 31, 2025

Copy link
Copy Markdown
Collaborator Author

Can you try now? I'm looking into the over-validtion issue.

@edgarrmondragon

edgarrmondragon commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

Can you try now? I'm looking into the over-validtion issue.

Aha, that did it!

@henryiii henryiii merged commit 97e0fad into wntrblm:main Jan 31, 2025
@henryiii henryiii deleted the henryiii/fix/uvx branch January 31, 2025 20:12
@henryiii henryiii mentioned this pull request Jan 31, 2025
Merged
@edgarrmondragon edgarrmondragon mentioned this pull request Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@edgarrmondragon edgarrmondragon edgarrmondragon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henryiii @edgarrmondragon