Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: rename rst files to avoid conflict with service names #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dizcology merged 6 commits into from
Oct 18, 2023
Merged

fix: rename rst files to avoid conflict with service names #1706

dizcology merged 6 commits into from
Oct 18, 2023

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jul 28, 2023

This PR removes the need for workarounds here and here where the autogenerated docs/index.rst and docs/<API>/services.rst are excluded.

Fixes #825 🦕

@parthea parthea requested a review from a team as a code owner July 28, 2023 22:51
@product-auto-label product-auto-label bot added the size: u Pull request is empty. label Jul 28, 2023
@parthea parthea marked this pull request as draft August 9, 2023 19:17
@parthea parthea closed this Sep 6, 2023
@parthea parthea reopened this Sep 7, 2023
@parthea parthea marked this pull request as ready for review September 7, 2023 19:30
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2023
@dizcology dizcology mentioned this pull request Sep 8, 2023
Merged
@parthea
Copy link
Contributor Author

parthea commented Oct 16, 2023

A new release of gapic-generator will be created today. Please only merge this PR if you're ok with the changes being released immediately.

@dizcology dizcology merged commit 70c3db5 into main Oct 18, 2023
@dizcology dizcology deleted the rename-rst-files branch October 18, 2023 15:31
@release-please release-please bot mentioned this pull request Oct 18, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 18, 2023
@release-please
chore(main): release 1.11.9 (#1811)
ed1d196 
🤖 I have created a release *beep* *boop*
---


## [1.11.9](https://togithub.com/googleapis/gapic-generator-python/compare/v1.11.8...v1.11.9) (2023-10-18)


### Bug Fixes

* Rename rst files to avoid conflict with service names ([#1706](https://togithub.com/googleapis/gapic-generator-python/issues/1706)) ([70c3db5](https://togithub.com/googleapis/gapic-generator-python/commit/70c3db5ae1bac69e8ade13e4608af60c824e7870))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dizcology dizcology dizcology approved these changes

Assignees

@dizcology dizcology

Labels

size: u Pull request is empty.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error during client generation self referenced toctree found due to service named services

2 participants

@parthea @dizcology