Codestin Search App

thatblindgeye · 2023-06-29T14:58:34Z

@mceledonia @mcoker This draft currently only extends inline support to the plain button. I did try seeing what similar styling might look like for other button variants, for example the primary variant:

One thing to note is that with the Tabs component's action buttons (close and help), the icon becomes a little bigger than it currently is (can be fixed by adding a font size CSS var for pf-v5-c-tabs__item-action), and the outline on focus gets a little overlapped on the top and bottom:

We could use the current outline offset in the Tabs css (-0.1875rem), though that might make it feel cramped using --pf-v5-global--FontSize--xs (worse if the font size is custom and smaller than this):

This is also assuming we'd want to move the button styling out of the Tabs scss. If not, then it's a bit simpler to keep the pf-v5-c-tabs__item-action .pf-v5-c-button block and add the outline offset there.

patternfly-build · 2023-06-29T15:03:25Z

Preview: https://patternfly-pr-5696.surge.sh

A11y report: https://patternfly-pr-5696-a11y.surge.sh

srambach · 2023-08-15T19:33:51Z

src/patternfly/components/Button/button.scss

    background-color: var(--#{$button}--m-plain--BackgroundColor);

+    &.pf-m-inline {
+      padding: var(--#{$button}--m-plain--m-inline--PaddingTop) var(--#{$button}--m-plain--m-inline--PaddingRight) var(--#{$button}--m-plain--m-inline--PaddingBottom) var(--#{$button}--m-plain--m-inline--PaddingLeft);


Do you want to go ahead and make this logical properties?

Do we plan on updating CSS vars similarly at any point, e.g. instead of --component--PaddingTop => --component--PaddingBlockStart or something along those lines? Probably makes more sense to keep the PaddingTop etc var names to be less confusing, but curious if that's on the roadmap in regards to RTL.

@Coker and I talked about that - we were thinking to keep the variables as is because that would be a sweeping breaking change.

mcoker

Nice! I left some comments, but I wonder if we should look at this overall. I think there are probably 2 use cases here:

Use for a small/compact plain button outlined in #5351
An "inline" button that adapts its size to the context where it's used.

I think this is more along the lines of an inline button, but the left/right padding set to "sm" doesn't seem ideal as the text scales. If we wanted the padding to scale, it could be based off of the font-size (1em). Though if we followed the non-inline plain button as a guide for that padding, its padding is 16px, so the left/right would just be 1em, which is too big as the button icon size scales down.

There is a comment in the original issue around discussing a product need for this #5351 (comment)

@nicolethoen do you recall that conversation? I looked in the office hours agenda before that comment and skimmed a couple of the recordings and didn't see that discussion.

mcoker · 2023-08-17T02:25:18Z

src/patternfly/components/Button/button.scss

  --#{$button}--m-plain--active--Color: var(--#{$pf-global}--Color--100);
  --#{$button}--m-plain--disabled--Color: var(--#{$pf-global}--disabled-color--200);
  --#{$button}--m-plain--disabled--BackgroundColor: transparent;
+  --#{$button}--m-plain--m-inline--FontSize: inherit;


inherit (and unset and initial) can't be used as the value of a CSS var, and have that value come out of the var() function that refers to it. You'll need to use inherit as the fallback to a CSS var in the var() function. From there you can trigger the fallback by setting the var's value to initial. Technically inherit will trigger the fallback if one is set, too, but initial is the designated value to always trigger the fallback.
You can read about that here - https://www.w3.org/TR/css-variables-1/#example-ee865e1b

Your PR is working because in font-size: var(--#{$button}--m-plain--m-inline--FontSize);, the custom property in the var() function is invalid, so var() is returning initial as the value... and the initial value for font-size is inherit. It's a little confusing because the property you're using the var in has an initial value of what you're trying to update it to. I created a codepen that (maybe?) shows it a little more clearly https://codepen.io/mcoker/pen/yLGBxgP

Ah interesting! 🤯 The codepen definitely helps show it

src/patternfly/components/Button/button.scss

mcoker · 2023-08-17T02:31:06Z

src/patternfly/components/Button/button.scss

+  --#{$button}--m-plain--m-inline--PaddingRight: var(--#{$pf-global}--spacer--sm);;
+  --#{$button}--m-plain--m-inline--PaddingBottom: 0;
+  --#{$button}--m-plain--m-inline--PaddingLeft: var(--#{$pf-global}--spacer--sm);;
+  --#{$button}--m-plain--m-inline--LineHeight: normal;


there is a global var for this that we use for body text that looks like we should use?

patternfly/src/patternfly/sass-utilities/scss-variables.scss

Line 224 in 56b4f3f

$pf-v5-global--LineHeight--md: 1.5 !default;

Suggested change

--#{$button}--m-plain--m-inline--LineHeight: normal;

--#{$button}--m-plain--m-inline--LineHeight: var(--#{$pf-global}--LineHeight--md);

Updating from normal to var(--#{$pf-global}--LineHeight--md) causes a slight difference in height between the button and whatever text it might be next to, with the button height slightly exceeding the height of the text next to it.

With the global var:

With the normal keyword:

Screenshots are from Firefox but Chrome has similar height differences, which get more significant as the font size increases. Though this could possibly depend how exactly a plain+inline button would actually be used... wdyt?

src/patternfly/components/Button/button.scss

mcoker · 2023-08-17T02:38:59Z

src/patternfly/components/Button/examples/Button.md

  <i class="fas fa-times" aria-hidden="true"></i>
 {{/button}}
+
+<span style="font-size: 12px;">


I would add these in a new example block so we can add '```hbs isBeta', and we'll need to update .pf-m-inline or add a new row to the docs for plain inline

thatblindgeye · 2023-08-17T12:43:52Z

Use for a small/compact plain button

@mcoker that's something I had thought about, but it seemed less of an "inline" button and more of a "small" variant of a plain button. Maybe we offer both a plain+inline button as well as a small/compact+plain button variant, with the latter applying the smaller font size as well as a smaller padding? Throwing something together locally, here's what that could look like (keeping the same var(--#{$button}--m-small--FontSize font-size applied, then just updating the paddings so top/bottom gets the xs spacer and left/right gets sm, but could go a bit smaller all around):

I think this is more along the lines of an inline button, but the left/right padding set to "sm" doesn't seem ideal as the text scales. If we wanted the padding to scale, it could be based off of the font-size (1em). Though if we followed the non-inline plain button as a guide for that padding, its padding is 16px, so the left/right would just be 1em, which is too big as the button icon size scales down.

I could look more into a more complex/accurate calculation, but applying a padding left/right of 1em / x (where x is either 3 or 2, depending on what line-height value we go with) results in this:

Top and bottom examples are basically the same from this PR, slightly adjusted font sizes on the wrapper spans, but the middle on is an h1 wrapped around the text and button

mcoker · 2023-08-17T14:30:27Z

@thatblindgeye that all seems on point to me. We call those buttons "small" now. I wonder if this is a case for a "compact" button variant, assuming there could be a meaningful distinction between small and compact.

I know I created the original issue for this change, but I'm not totally clear on the role of an inline button. And I'm wondering if a compact button would negate any immediate need for an inline variant. From what I can tell, the padding/math in your inline screenshots looks good to me though.

I'm interested in the user's comment from the issue around their need for this feature, too, as well as any design input. cc @andrew-ronaldson @lboehling

Side note, I'd love to see the "small" buttons in a separate example block called "small", they get lost in the variations block now.

thatblindgeye · 2023-08-17T14:43:07Z

If we wanted to differentiate between "small" and "compact", "small" could refer to the font size while "compact" refer to both the font size and padding (or just padding?).

That all sounds good, though, will wait for some feedback from everyone else. Depending where we end up going with this PR I'll also move those small buttons to a separate example as part of this.

nicolethoen · 2023-08-17T21:05:47Z

@nicolethoen do you recall that conversation? I looked in the office hours agenda before that comment and skimmed a couple of the recordings and didn't see that discussion.

I don't - I looked at which office hours he'd be referring to - the one on March 15. And it must have been a question posed after the recording was stopped 🙁

andrew-ronaldson

Looks good to me but defer to Coker and Sarah on any outstanding code changes.

thatblindgeye · 2023-08-29T18:17:09Z

@andrew-ronaldson @mcoker this can use another look after latest updates. I replaced the previous inline styling with a simpler compact styling as that was along the lines of the initial use-case.

I also moved the small buttons to their own example per convo above and to align with the React examples.

mcoker

💪🚀👍

andrew-ronaldson · 2023-09-14T15:48:13Z

Happy days. Looks great!

src/patternfly/components/Button/examples/Button.md

srambach

👍

patternfly-build · 2023-09-18T20:37:25Z

🎉 This PR is included in version 5.1.0-prerelease.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

* chore(select): fixed text in HTML example to show multiple checks can be selected (#5663) * chore: Update release.yml to node 18 [ci skip] * chore: add superclean npm script (#5798) * chore(options-menu): updated markup to match react component (#5809) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.3 (#5720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (#5756) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updated use of flex start/end to be more compatible (#5807) * fix(chip): add margin for badge when used in text element (#5844) * feat(global): added RTL support (#5778) * fix: added tree view icon (#5845) * fix: added tree view icon * chore: put treeviewicon in alphabetical order * chore: rtl fixes, screenshots (#5854) * chore: rtl fixes, screenshots * chore: checkin screenshots * chore(deps): update dependency @patternfly/documentation-framework to v5.1.7 (#5852) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: enable RTL switcher on full page examples (#5859) * docs: update location of and references to docs to consolidate and organize information. (#5773) * fix: added base, wizard, pagination RTL styles (#5860) * chore(Accordion,ExpandableSection): added more RTL styling (#5861) * fix(RTL): refactor mixins, add slider rtl styles (#5867) * fix(nav): added optional text wrapper for nav text (#5868) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.9 (#5863) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Toolbar): updated toolbar pagination structure (#5862) * fix(breadcrumb): added rtl support (#5870) * chore(card): updated horiz demo image (#5875) * chore(Alert,NotificationDrawer): added additional rtl styling (#5866) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.10 (#5880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Nav, Menu): apply RTL fixes (#5873) * fix(clipboard-copy): added rtl styles (#5876) * fix(page): added rtl styles (#5878) * fix(calendar-month): rtl support (#5869) * chore(Card,Tile): apply RTL fixes (#5881) * fix: added tabs and jump links rtl styles (#5877) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.11 (#5885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(DataList): added additional rtl styling (#5871) * chore(DataList): added additional rtl styling * Add comment to update notif badge in breaking change * fix(popover, tooltip): added rtl styles (#5882) * fix(tree-view): added rtl styles (#5883) * chore(Table): added additional RTL styling (#5887) * chore(Drawer): transforms and shadows on RTL drawer (#5888) * fix(forms): updated rtl styles (#5889) * fix(skeleton): added rtl styles (#5891) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.12 (#5894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(slider): added root decl for var to create react token (#5895) * chore(ModalBox): center modal for workspace in RTL (#5893) * fix(rtl): fixes truncate rtl (#5874) * fix(ModalBox): fix centering on mobile (#5905) * chore: added backstop as dev dependency, update config (#5904) * chore(popover): center examples (#5906) * fix(nav): updated example css (#5903) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.14 (#5909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: remove workspace RTL classes (#5912) * chore: update screenshots (#5915) * fix: Update upload-preview.js to use new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.1.15 (#5916) * chore(deps): update dependency @patternfly/react-table to v5.0.1 (#5914) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.0.1 (#5910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-core to v5.0.1 (#5913) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: mirror fa-sort icon (#5920) * fix: mirror bg image position in rtl (#5922) * fix(progress): updated indicator direction (#5923) * chore: update readme to reference new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.2.0 (#5925) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(code-editor): make code box and header LTR (#5928) * fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block * fix(banner): fixed invalid dark theme color declaration (#5933) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.2 (#5934) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.3 (#5940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(clipboard-copy): add code example with rtl support (#5941) * fix(card): removed border from clickable/selectable selected (#5935) * feat(Button): extended inline styling (#5696) * fix(menu): updated drilldown breadcrumb menu icons to work in RTL (#5924) * fix(toolbar): fix expand all icon in RTL (#5937) * chore(toolbar): mirror expand all icon in rtl * chore: update * chore: use icon shouldMirrorRTL param * fix(popover/tooltip): revert arrow logical prop positioning (#5952) * fix(popover/tooltip): revert arrow logical prop positioning * chore: add missing local css import * chore(screenshots): updated full page screenshots (#5960) * chore(deps): update dependency @patternfly/react-core to v5.1.1 (#5975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps-dev): bump postcss from 8.4.27 to 8.4.31 (#5971) * chore(Toolbar): increase workspace container height (#5962) * chore(screenshots): update visual regression screenshots (#5959) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.17 (#5961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.1 (#5977) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.1 (#5974) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(check-radio): added aria-describedby to check/radio (#5969) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.18 (#5982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(brand/card): update examples to display logo in dark theme (#5681) * fix(input): standardized check and radio alignment (#5947) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.19 (#5985) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.20 (#5994) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump @babel/traverse from 7.22.15 to 7.23.2 (#6001) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.15 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Switch): updated focus style to focus-visible (#5995) * chore(menu-toggle): updated demos to use menu-toggle (#5782) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.24 (#6014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(Accordion): added left-aligned toggle variant (#5987) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.26 (#6020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: V6 merge main.10.30 (#6023) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.0 (#6027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): reverts to pre-v6 merge (#6038) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.1 (#6040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(globals): update invalid selector in global css (#6044) * feat(breaker): bump this version to 6.0 (#5800) BREAKING CHANGE: 6.0.0-alpha.0 * fix: white space change to kick off dry run * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (#5843) * feat(Button): adds tokens and applies to buttons (#5908) * feat(table): apply tokens from hackathon (#5965) * feat(menu-toggle): add in work from hackathon (#5931) * feat(nav): adds tokens to page and nav (#5942) * chore(tokens): update tokens from figma (#5970) * feat(page): page and masthead updates from hackathon (#5968) * chore(v6): merge main into v6 (#5981) * fix(tokens): add dark theme blend mode token (#5992) * feat(notificationBadge): refactor with tokens (#5991) * chore(masthead ): applied tokens (#6004) * feat(alert): apply tokens (#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (#6025) * fix(box-shadow): typo in box shadow token names (#6039) * fix(badge): adds tokens, dropdown toggle icon (#6037) * feat(hint): apply tokens (#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ashley Ray <[email protected]> Co-authored-by: Nicole Thoen <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Sarah Rambacher <[email protected]> Co-authored-by: Matt Nolting <[email protected]> Co-authored-by: Jenny <[email protected]>

* chore(select): fixed text in HTML example to show multiple checks can be selected (patternfly#5663) * chore: Update release.yml to node 18 [ci skip] * chore: add superclean npm script (patternfly#5798) * chore(options-menu): updated markup to match react component (patternfly#5809) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.3 (patternfly#5720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (patternfly#5756) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updated use of flex start/end to be more compatible (patternfly#5807) * fix(chip): add margin for badge when used in text element (patternfly#5844) * feat(global): added RTL support (patternfly#5778) * fix: added tree view icon (patternfly#5845) * fix: added tree view icon * chore: put treeviewicon in alphabetical order * chore: rtl fixes, screenshots (patternfly#5854) * chore: rtl fixes, screenshots * chore: checkin screenshots * chore(deps): update dependency @patternfly/documentation-framework to v5.1.7 (patternfly#5852) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: enable RTL switcher on full page examples (patternfly#5859) * docs: update location of and references to docs to consolidate and organize information. (patternfly#5773) * fix: added base, wizard, pagination RTL styles (patternfly#5860) * chore(Accordion,ExpandableSection): added more RTL styling (patternfly#5861) * fix(RTL): refactor mixins, add slider rtl styles (patternfly#5867) * fix(nav): added optional text wrapper for nav text (patternfly#5868) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.9 (patternfly#5863) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Toolbar): updated toolbar pagination structure (patternfly#5862) * fix(breadcrumb): added rtl support (patternfly#5870) * chore(card): updated horiz demo image (patternfly#5875) * chore(Alert,NotificationDrawer): added additional rtl styling (patternfly#5866) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.10 (patternfly#5880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Nav, Menu): apply RTL fixes (patternfly#5873) * fix(clipboard-copy): added rtl styles (patternfly#5876) * fix(page): added rtl styles (patternfly#5878) * fix(calendar-month): rtl support (patternfly#5869) * chore(Card,Tile): apply RTL fixes (patternfly#5881) * fix: added tabs and jump links rtl styles (patternfly#5877) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.11 (patternfly#5885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(DataList): added additional rtl styling (patternfly#5871) * chore(DataList): added additional rtl styling * Add comment to update notif badge in breaking change * fix(popover, tooltip): added rtl styles (patternfly#5882) * fix(tree-view): added rtl styles (patternfly#5883) * chore(Table): added additional RTL styling (patternfly#5887) * chore(Drawer): transforms and shadows on RTL drawer (patternfly#5888) * fix(forms): updated rtl styles (patternfly#5889) * fix(skeleton): added rtl styles (patternfly#5891) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.12 (patternfly#5894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(slider): added root decl for var to create react token (patternfly#5895) * chore(ModalBox): center modal for workspace in RTL (patternfly#5893) * fix(rtl): fixes truncate rtl (patternfly#5874) * fix(ModalBox): fix centering on mobile (patternfly#5905) * chore: added backstop as dev dependency, update config (patternfly#5904) * chore(popover): center examples (patternfly#5906) * fix(nav): updated example css (patternfly#5903) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.14 (patternfly#5909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: remove workspace RTL classes (patternfly#5912) * chore: update screenshots (patternfly#5915) * fix: Update upload-preview.js to use new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.1.15 (patternfly#5916) * chore(deps): update dependency @patternfly/react-table to v5.0.1 (patternfly#5914) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.0.1 (patternfly#5910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-core to v5.0.1 (patternfly#5913) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: mirror fa-sort icon (patternfly#5920) * fix: mirror bg image position in rtl (patternfly#5922) * fix(progress): updated indicator direction (patternfly#5923) * chore: update readme to reference new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.2.0 (patternfly#5925) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(code-editor): make code box and header LTR (patternfly#5928) * fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block * fix(banner): fixed invalid dark theme color declaration (patternfly#5933) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.2 (patternfly#5934) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.3 (patternfly#5940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(clipboard-copy): add code example with rtl support (patternfly#5941) * fix(card): removed border from clickable/selectable selected (patternfly#5935) * feat(Button): extended inline styling (patternfly#5696) * fix(menu): updated drilldown breadcrumb menu icons to work in RTL (patternfly#5924) * fix(toolbar): fix expand all icon in RTL (patternfly#5937) * chore(toolbar): mirror expand all icon in rtl * chore: update * chore: use icon shouldMirrorRTL param * fix(popover/tooltip): revert arrow logical prop positioning (patternfly#5952) * fix(popover/tooltip): revert arrow logical prop positioning * chore: add missing local css import * chore(screenshots): updated full page screenshots (patternfly#5960) * chore(deps): update dependency @patternfly/react-core to v5.1.1 (patternfly#5975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps-dev): bump postcss from 8.4.27 to 8.4.31 (patternfly#5971) * chore(Toolbar): increase workspace container height (patternfly#5962) * chore(screenshots): update visual regression screenshots (patternfly#5959) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.17 (patternfly#5961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.1 (patternfly#5977) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.1 (patternfly#5974) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(check-radio): added aria-describedby to check/radio (patternfly#5969) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.18 (patternfly#5982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(brand/card): update examples to display logo in dark theme (patternfly#5681) * fix(input): standardized check and radio alignment (patternfly#5947) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.19 (patternfly#5985) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.20 (patternfly#5994) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump @babel/traverse from 7.22.15 to 7.23.2 (patternfly#6001) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.15 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Switch): updated focus style to focus-visible (patternfly#5995) * chore(menu-toggle): updated demos to use menu-toggle (patternfly#5782) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.24 (patternfly#6014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(Accordion): added left-aligned toggle variant (patternfly#5987) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.26 (patternfly#6020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: V6 merge main.10.30 (patternfly#6023) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.0 (patternfly#6027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): reverts to pre-v6 merge (patternfly#6038) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.1 (patternfly#6040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(globals): update invalid selector in global css (patternfly#6044) * feat(breaker): bump this version to 6.0 (patternfly#5800) BREAKING CHANGE: 6.0.0-alpha.0 * fix: white space change to kick off dry run * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (patternfly#5843) * feat(Button): adds tokens and applies to buttons (patternfly#5908) * feat(table): apply tokens from hackathon (patternfly#5965) * feat(menu-toggle): add in work from hackathon (patternfly#5931) * feat(nav): adds tokens to page and nav (patternfly#5942) * chore(tokens): update tokens from figma (patternfly#5970) * feat(page): page and masthead updates from hackathon (patternfly#5968) * chore(v6): merge main into v6 (patternfly#5981) * fix(tokens): add dark theme blend mode token (patternfly#5992) * feat(notificationBadge): refactor with tokens (patternfly#5991) * chore(masthead ): applied tokens (patternfly#6004) * feat(alert): apply tokens (patternfly#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (patternfly#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (patternfly#6025) * fix(box-shadow): typo in box shadow token names (patternfly#6039) * fix(badge): adds tokens, dropdown toggle icon (patternfly#6037) * feat(hint): apply tokens (patternfly#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ashley Ray <[email protected]> Co-authored-by: Nicole Thoen <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Sarah Rambacher <[email protected]> Co-authored-by: Matt Nolting <[email protected]> Co-authored-by: Jenny <[email protected]>

thatblindgeye marked this pull request as ready for review July 6, 2023 18:41

thatblindgeye requested review from mceledonia and mcoker July 6, 2023 18:41

srambach reviewed Aug 15, 2023

View reviewed changes

thatblindgeye force-pushed the iss5351_buttonInline_variants branch from 45f0100 to ee55b02 Compare August 15, 2023 20:01

mcoker reviewed Aug 17, 2023

View reviewed changes

mcoker requested a review from andrew-ronaldson August 17, 2023 03:02

andrew-ronaldson approved these changes Aug 22, 2023

View reviewed changes

thatblindgeye force-pushed the iss5351_buttonInline_variants branch from ee55b02 to 7d46e9c Compare August 29, 2023 18:14

thatblindgeye force-pushed the iss5351_buttonInline_variants branch from 7d46e9c to 5797c83 Compare September 13, 2023 13:18

mcoker approved these changes Sep 14, 2023

View reviewed changes

mcoker requested a review from srambach September 14, 2023 20:02

thatblindgeye force-pushed the iss5351_buttonInline_variants branch from 5797c83 to 0461451 Compare September 15, 2023 14:49

andrew-ronaldson removed the request for review from mceledonia September 18, 2023 12:12

srambach reviewed Sep 18, 2023

View reviewed changes

src/patternfly/components/Button/examples/Button.md Outdated Show resolved Hide resolved

Eric Olkowski added 6 commits September 18, 2023 13:46

feat(Button): extended inline styling

2a87a5d

feat(Button): updated logical properties

2838b60

Replaced inline styling with compact

27f1a42

Updated modifier to no-padding

5fb86c4

Added documentation for use

73e23ed

Updated verbiage for no padding class

ddedd51

thatblindgeye force-pushed the iss5351_buttonInline_variants branch from 0461451 to ddedd51 Compare September 18, 2023 17:46

thatblindgeye requested a review from srambach September 18, 2023 17:46

srambach approved these changes Sep 18, 2023

View reviewed changes

mcoker merged commit 6fe9185 into patternfly:main Sep 18, 2023

patternfly-build added the released on @prerelease label Sep 18, 2023

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023

feat(Button): extended inline styling (patternfly#5696)

1e3e171

	--#{$button}--m-plain--m-inline--LineHeight: normal;
	--#{$button}--m-plain--m-inline--LineHeight: var(--#{$pf-global}--LineHeight--md);

Conversation

thatblindgeye commented Jun 29, 2023

Uh oh!

patternfly-build commented Jun 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thatblindgeye commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcoker commented Aug 17, 2023

Uh oh!

thatblindgeye commented Aug 17, 2023

Uh oh!

nicolethoen commented Aug 17, 2023

Uh oh!

andrew-ronaldson left a comment

Choose a reason for hiding this comment

Uh oh!

thatblindgeye commented Aug 29, 2023

Uh oh!

mcoker left a comment

Choose a reason for hiding this comment

Uh oh!

andrew-ronaldson commented Sep 14, 2023

Uh oh!

Uh oh!

srambach left a comment

Choose a reason for hiding this comment

Uh oh!

patternfly-build commented Sep 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

patternfly-build commented Jun 29, 2023 •

edited

Loading

thatblindgeye commented Aug 17, 2023 •

edited

Loading