chore(a11y): update logic for determining URLs to test#5705
chore(a11y): update logic for determining URLs to test#5705mcoker merged 1 commit intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-pr-5705.surge.sh A11y report: https://patternfly-pr-5705-a11y.surge.sh |
mcoker
left a comment
There was a problem hiding this comment.
LGTM - just one thing, seems like we might be missing context selector in this group?
| if (path.match(/\/patterns\/.*\/html-demos$/g)) { | ||
| return path.replace(/\/html-demos$/, ''); | ||
| } else { | ||
| if ( |
There was a problem hiding this comment.
Do we need to add context selector here? BTW - not sure if this is an issue but the demo page shows up first now, maybe that's intentional since the demos are still valid - they would just ideally be built using menu/menu toggle. Since core isn't going to have a context selector component, I don't know if the context selector demos belong there though. Or maybe the nav link needs a "demo" badge, like password strength/generator?
|
so, context-selector has html demos as its default tab. Its case in handled on line 13 of this file and its the only deprecated component which has any demos at all. the context-selector demos use the deprecated context-selector. I think that's the only place where that's the case, because generally, we've rewritten old demos to use recommended/non-deprecated components, so we do want them to appear before the deprecated component docs. The context-selector docs is the exception to that rule. Tab order is defined in the documentation-framework. |
|
🎉 This PR is included in version 5.1.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes: #5704