Building on #827260: Add querystring, fragment, and token support. and #996974: Fatal error since classes are not an array I have a patch that adds some missing attributes (title, rel, target) and uses the Views token replacement functionality. This works in my environment, but has not been heavily tested.

CommentFileSizeAuthor
#4 views_linkarea-add-real-tokens-and-more-attributes-1650012-4.patch9.48 KBsteven.wichers
#2 views_linkarea-add-real-tokens-and-more-attributes-1650012-2.patch10.11 KBsteven.wichers
views_linkarea-add-real-tokens-and-more-attributes.patch9.72 KBsteven.wichers

Comments

steven.wichers’s picture

steven.wichers commented

Heads up, it doesn't appear as if the attributes save. I believe it's because I added a fieldset without testing. When I get some free time I'll debug and reroll the patch. In the mean time, you can remove the fieldset that wraps the attributes and I believe everything should function as expected.

steven.wichers’s picture

steven.wichers commented
StatusFileSize
new views_linkarea-add-real-tokens-and-more-attributes-1650012-2.patch10.11 KB

Fixed issue with the fieldset. Tested that the attributes get saved correctly now.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Needs review

Please review this patch to get it into the next dev release.

I will have a look myself too.

steven.wichers’s picture

steven.wichers commented
Version: 7.x-1.0 » 7.x-1.x-dev
StatusFileSize
new views_linkarea-add-real-tokens-and-more-attributes-1650012-4.patch9.48 KB

Re-rolled patch against latest dev. Verified functionality with regards to link attributes and field tokens. The only functional changes between the previous stable version and development that I noticed was the addition of checking menu permissions. I did not test this functionality.

Note that this patch contains additional bug fixes that are not in the above patch and were only in my private branch of this module. Specifically there are a couple of additional checks to make sure we're not throwing notices, and the addition of decode_entities() before using l().

weri’s picture

weri commented

I applied the patch to the latest dev version and tested it. Everything seems to work. I hope the patch gets in in the next (dev) release.

kristofferwiklund’s picture

kristofferwiklund commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Tested patch. Works great.

minoroffense’s picture

minoroffense commented
Status: Reviewed & tested by the community » Fixed

Added some modifications but the patch is in now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.