After reviewing some of the issues, mainly
- #1650012: More attributes, correct class attribute usage, and real views token support
- #1928746: add an option to add text on link as a HTML text
- #2119615: Allow replacement tokens from the first row like global text area
- #1722258: add an option to add the current page as a query destination
I feel I wanted to bring all these together and add a few more things to the mix.
First of all, the default limit of 64 characters on the querystring has meant that one could easily run that field out with a fairly complex and long querystring, so I've increased it to 2048. Doesn't mean you should use it all. Some browsers won't like it. But at least it's there to work with.
Furthermore, if anyone tried to work with Tokens and the Prepopulate module, you know the feeling of having your URL not work and things just end up being basically Global: Custom Text. Well, this patch to 7.x-1.0 of the module attempts to rectify this.
I ran into the need to use { } curly braces for this. Check out the option "Use curly brackets in tokens." to understand what I mean. By having the choice to have tokens for this Global Link field be square brackets or curly brackets means you can have some pretty awesome querystrings.
?uuid=e6305d24-5d22-43d1-a5db-f61aafcce519&changed=%5Bedit_link%5D&field_source=542&destination=node/542/display
In the result above, the querystring in the Global Link settings looks like this:
uuid={uuid}&changed=[edit_link]&field_source=!1
Along with the "Set destination as the current page" option checked.
Hope this helps everyone.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | views_linkarea-ultimate-1.x-dev.patch | 16.19 KB | wilco |
Comments
Comment #1
wilco commentedComment #2
wilco commentedComment #3
wilco commentedFound an issue in the way I dealt with array_map() parse_str() results.
I've corrected it in this patch file.
Comment #4
wilco commentedComment #5
wilco commentedComment #6
Crell commentedIt looks like this patch was made against a download of the module... and a very old one at that since it still has CVS tags from 2010. That makes it unusable in its current form. Please make patches from a fresh Git checkout of the 1.x-dev branch.
I also don't think that merging the various changes into a single patch is wise. That makes it much harder to review and understand the implications of each change. Let's stick to patch-per-change as usual.
Comment #7
wilco commentedSure, no problem.. I'll break them out and fix. Odd about the CVS stuff, since I used the git repo to work with.
Maybe because it was against 1.0 of the module.
I'll re-hash it for dev though.
Comment #8
wilco commentedComment #9
wilco commentedComment #10
wilco commentedComment #11
wilco commentedThis is a clean up of the file which had dd() commands in it and a bad location for the Token replacement function.
Comment #12
wilco commentedComment #13
wilco commentedComment #14
wilco commentedComment #15
wilco commentedComment #16
kristofferwiklund commentedWhy add all issues in one?
Could we solve one issue a a time. It makes it much more easy to track why things where changed.
Maybe we should use the core pattern to create a META issue instead.
And that should that be for version 7.x-1.1.
Comment #17
Crell commentedI'm going to go ahead and close this. As noted above, this should be individual patches, not a massive rewrite.
With Drupal 8 out now, the D7 module is now in maintenance-only mode. I'm not planning anything radical for it at this point. If someone else wants to take over the module and port it to Drupal 8 let me know, but I do not have any big plans for it.
Comment #18
minoroffense commentedI'll be working through the individual patches to get all this functionality integrated. Once that's done we'll do a 1.1 for the module.