Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/gapic-generator-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.40.9
Choose a base ref
...
head repository: googleapis/gapic-generator-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.40.10
Choose a head ref
  • 4 commits
  • 7 files changed
  • 4 contributors

Commits on Feb 17, 2021

  1. chore: cancel preexisting workflow runs, refactor workflow file (#775)

    Pushing to an open PR should (hopefully) cancel preexisting actions.
    Remove dead CI requirements.
    software-dov authored Feb 17, 2021
    Configuration menu
    Copy the full SHA
    d2fe3c6 View commit details
    Browse the repository at this point in the history
  2. fix: from_service_account constructors for async clients (#779)

    Currently, creating async clients with constructor works fine:
    
    from google.cloud import vision
    
    client = vision.ImageAnnotatorAsyncClient()
    print(type(client))
    prints: <class 'google.cloud.vision_v1.services.image_annotator.async_client.ImageAnnotatorAsyncClient'>
    
    Using from_service_account_* methods on the other hand return sync client:
    
    client = vision.ImageAnnotatorAsyncClient.from_service_account_file("service_account.json")
    print(type(client))
    This gives <class 'google.cloud.vision_v1.services.image_annotator.client.ImageAnnotatorClient'>, which is just a normal synchronous client.
    
    This happens because these functions are linked to sync clients' methods. Now it's fixed to call the same method, but with proper class.
    ilango100 authored Feb 17, 2021
    Configuration menu
    Copy the full SHA
    029923f View commit details
    Browse the repository at this point in the history
  3. fix: ignore unknown fields returned from server for REST (#777)

    Otherwise the client may throw an exception if the server is newer than the client (i.e. some of the returned messages have new fields).
    A tracking bug: #780
    vam-google authored Feb 17, 2021
    Configuration menu
    Copy the full SHA
    a70b078 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Configuration menu
    Copy the full SHA
    e5d630f View commit details
    Browse the repository at this point in the history
Loading