Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

feat!: drop node8 support, support for async iterators#568

Merged
xiaozhenliu-gg5 merged 5 commits into
masterfrom
finally-drop-node8
Apr 1, 2020
Merged

feat!: drop node8 support, support for async iterators#568
xiaozhenliu-gg5 merged 5 commits into
masterfrom
finally-drop-node8

Conversation

@alexander-fenster

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
@alexander-fenster alexander-fenster requested a review from bcoe March 31, 2020 20:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
@xiaozhenliu-gg5 xiaozhenliu-gg5 added the automerge Merge the pull request once unit tests and other checks pass. label Mar 31, 2020
@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

2 similar comments
@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

2 similar comments
@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@codecov

codecov Bot commented Apr 1, 2020

Copy link
Copy Markdown

Codecov Report

Merging #568 into master will increase coverage by 5.58%.
The diff coverage is 99.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
+ Coverage   92.24%   97.82%   +5.58%     
==========================================
  Files          15       15              
  Lines       12481    13753    +1272     
  Branches      484      592     +108     
==========================================
+ Hits        11513    13454    +1941     
+ Misses        963      294     -669     
  Partials        5        5
Impacted Files Coverage Δ
src/v1p4beta1/image_annotator_client.ts 96.9% <100%> (+9.34%) ⬆️
src/v1p2beta1/image_annotator_client.ts 94.86% <100%> (+1.79%) ⬆️
src/helpers.ts 100% <100%> (ø) ⬆️
src/v1p1beta1/image_annotator_client.ts 93.68% <100%> (+1.39%) ⬆️
src/v1/image_annotator_client.ts 97.31% <100%> (+7.37%) ⬆️
src/v1p3beta1/image_annotator_client.ts 96.53% <100%> (+9.1%) ⬆️
src/v1/product_search_client.ts 98.11% <99.01%> (+5.95%) ⬆️
src/v1p3beta1/product_search_client.ts 98.12% <99.02%> (+5.95%) ⬆️
src/v1p4beta1/product_search_client.ts 98.17% <99.06%> (+5.79%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c74fa...fff6457. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants