Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@craiglabenz
Copy link
Contributor

Uses direct access of pb2 object when iterating over Entity.properties. This reduces the time required to hydrate query results by 50%

@craiglabenz craiglabenz requested a review from a team May 25, 2021 16:41
@craiglabenz craiglabenz requested a review from a team as a code owner May 25, 2021 16:41
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 25, 2021
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label May 25, 2021
@craiglabenz craiglabenz changed the title Improve Protobuf2 Performance feat: Improve Protobuf2 Performance May 25, 2021
@tseaver tseaver changed the title feat: Improve Protobuf2 Performance fix(perf): improve performance unmarshalling entities from protobuf2 May 25, 2021
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label May 25, 2021
@tseaver
Copy link
Contributor

tseaver commented May 25, 2021

@craiglabenz I changed the title from feat: to fix(perf): because it should be semver-patch: no user-visible change to behavior, except the speedup.

@craiglabenz
Copy link
Contributor Author

Thanks for that commit name catch, @tseaver :)

@gcf-merge-on-green gcf-merge-on-green bot merged commit 0e5b718 into master May 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the pb2-performance branch May 25, 2021 16:58
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 25, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request May 25, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [2.1.3](https://www.github.com/googleapis/python-datastore/compare/v2.1.2...v2.1.3) (2021-05-25)


### Bug Fixes

* **perf:** improve performance unmarshalling entities from protobuf2 ([#175](https://www.github.com/googleapis/python-datastore/issues/175)) ([0e5b718](https://www.github.com/googleapis/python-datastore/commit/0e5b718a70368f656ede3a27174ef74ca324ab65))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the googleapis/python-datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants