fix: ensure ack() doesn't wait on stream messages #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix error propagation to streaming pull future
| except GoogleAPICallError as e: # noqa: F841 Flake8 thinks e is unused | ||
| self._unowned_executor.submit(lambda: self._fail(e)) # noqa: F821 | ||
| except GoogleAPICallError as e: | ||
| self._unowned_executor.submit(partial(self._fail, e)) |
Collaborator
Author
There was a problem hiding this comment.
you can't capture exceptions in lambda bindings
also fix error propagation to streaming pull future
manuelmenzella-google
approved these changes
Sep 13, 2021
google/cloud/pubsublite/cloudpubsub/internal/subscriber_impl.py
Outdated
Show resolved
Hide resolved
also fix error propagation to streaming pull future
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 13, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.1.3](https://www.github.com/googleapis/python-pubsublite/compare/v1.1.2...v1.1.3) (2021-09-13) ### Bug Fixes * ensure ack() doesn't wait on stream messages ([#234](https://www.github.com/googleapis/python-pubsublite/issues/234)) ([03db702](https://www.github.com/googleapis/python-pubsublite/commit/03db702c1f88982ed424bec3d99ae9d4bdc353bd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix error propagation to streaming pull future