Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mf2199
Copy link
Contributor

@mf2199 mf2199 commented Oct 30, 2020

The DB-API driver refactored from python-spanner-django repository, prior to its beta-release.

Some additional changes have been made to skip unit tests found incompatible with Python 2.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2020
@mf2199 mf2199 added api: spanner Issues related to the googleapis/python-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 31, 2020
@c24t c24t removed the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2020
@mf2199 mf2199 marked this pull request as ready for review November 2, 2020 19:42
@mf2199 mf2199 requested a review from a team as a code owner November 2, 2020 19:42
Copy link
Contributor

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll need a PR in https://github.com/googleapis/python-spanner-django to remove spanner_dbapi and then coordinate releasees. We can follow up with tests for 2.x.

@skuruppu skuruppu requested a review from larkee November 4, 2020 00:14
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Just one concern about NUMERIC loss of precision.

@c24t c24t mentioned this pull request Nov 10, 2020
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2020
@larkee larkee merged commit 2493fa1 into googleapis:master Nov 11, 2020
c24t pushed a commit to googleapis/python-spanner-django that referenced this pull request Nov 25, 2020
BREAKING CHANGE: DBAPI code was moved into python-spanner in
googleapis/python-spanner#160. This change removes it
from this repo and bumps the dependency on python-spanner to 2.0.0, the first
released version to include DBAPI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants