-
Notifications
You must be signed in to change notification settings - Fork 914
chore: Move to pnpm 10 #2836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: Move to pnpm 10 #2836
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
72b4d62 to
16af8d7
Compare
16af8d7 to
dc1de6e
Compare
dc1de6e to
79614d0
Compare
79614d0 to
efbcfdc
Compare
efbcfdc to
0212425
Compare
|
Oh wow ok thanks I'll have a look |
0212425 to
af65ce6
Compare
af65ce6 to
eea429e
Compare
bcb5571 to
f5a0bfd
Compare
f5a0bfd to
7849ef6
Compare
|
I was thinking that maybe some of the lifecycle scripts were necessary so I allow-listed them but Vercel still refuses to see any of the settings I added to the workspace file and/or the package.json I don't understand what's the problem and it all works fine locally. I'll give it another debugging round later. |
|
If buns causing issues can just use |
62580ba to
bf81aa0
Compare
bf81aa0 to
2e14c6c
Compare
2e14c6c to
6345fcb
Compare
28c9c24 to
7acdd0e
Compare
|
So it's really because Vercel is completely ignoring the fact that we allow-listed the I made this use |
|
@NWylynko ready for your review again 🙇 |
| onlyBuiltDependencies: | ||
| - bun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes it so that pnpm run build actually works locally and I'd like to have it to show Vercel support the configuration that should work.
|
It would be good to also update the contributing.md anywhere it says to use npm when working on the docs to instead use pnpm |
|
Good catch for the contributing ! I will modify this as well once this merges https://github.com/clerk/clerk?tab=readme-ov-file#5-optional-set-up-local-docs |
|
Ok now the test fails even though the last commit was unrelated :( |
🔎 Previews:
What does this solve?
Safer defaults for increased supply chain security
Related to https://linear.app/clerk/issue/SEC-210/add-minimumreleaseage-to-all-projects-using-npm
Related to https://linear.app/clerk/issue/SEC-209/enforce-pnpm-10-in-vercel-environments
What changed?
Move to pnpm 10 and delay package updates
Checklist