Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
72b4d62 to
16af8d7
Compare
16af8d7 to
dc1de6e
Compare
dc1de6e to
79614d0
Compare
79614d0 to
efbcfdc
Compare
efbcfdc to
0212425
Compare
|
The output folder is looking completely off from what it should be
|
|
Oh wow ok thanks I'll have a look |
0212425 to
af65ce6
Compare
af65ce6 to
eea429e
Compare
bcb5571 to
f5a0bfd
Compare
f5a0bfd to
7849ef6
Compare
28c9c24 to
7acdd0e
Compare
|
So it's really because Vercel is completely ignoring the fact that we allow-listed the I made this use |
|
@NWylynko ready for your review again 🙇 |
| onlyBuiltDependencies: | ||
| - bun |
There was a problem hiding this comment.
It makes it so that pnpm run build actually works locally and I'd like to have it to show Vercel support the configuration that should work.
|
It would be good to also update the contributing.md anywhere it says to use npm when working on the docs to instead use pnpm |
|
Good catch for the contributing ! I will modify this as well once this merges https://github.com/clerk/clerk?tab=readme-ov-file#5-optional-set-up-local-docs |
|
Ok now the test fails even though the last commit was unrelated :( |
|
Any updates on this @dominic-clerk ? |
|
I keep having discrepancies between the local and the build environment that I can't explain. It's not my main priority here but I'll return to it. |
cfa85dd to
fe58e29
Compare
|
Ok it finally works now! I didn't really change much from my last attempt, I wonder if there was a cache issue in Vercel. In any case, we should be good to go. https://clerk.com/docs/pr/dc-pnpm-10 When this merges we can merge https://github.com/clerk/clerk/pull/2057 |
🔎 Previews:
What does this solve?
Safer defaults for increased supply chain security
Related to https://linear.app/clerk/issue/SEC-210/add-minimumreleaseage-to-all-projects-using-npm
Related to https://linear.app/clerk/issue/SEC-209/enforce-pnpm-10-in-vercel-environments
What changed?
Move to pnpm 10 and delay package updates
Checklist