-
Notifications
You must be signed in to change notification settings - Fork 8.1k
[OID4VCI] Resolves all OAuthClient API issues in one PR #46014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5c99374 to
1e67fe9
Compare
|
@tdiesler JFYI - It does not close the: Please update it - you are probably missing some reference to another issue for this PR. |
022a94c to
05b1c1e
Compare
|
@forkimenjeckayang could you perhaps have a look at this PR or if you prefer the individual ones that address a single API each. In the issue descriptions you'll find the rational about these proposed changes. You can always meet me on slack for a quick chat. |
9af9ac1 to
b64b3ea
Compare
Hello @tdiesler |
8bbd9e7 to
8ffaddb
Compare
|
The individual PRs are now stand-alone. I would however prefer if this one gets merged instead (so I and others won't have to resolve unwanted merge conflicts) |
5656415 to
0bba0f2
Compare
2f24f55 to
6237c2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.forms.MultipleTabsLoginTest#testEmptyBaseUrlKeycloak CI - Forms IT (chrome) |
6237c2e to
e755acb
Compare
a034542 to
dbd2d63
Compare
53caae3 to
95c6bd4
Compare
Signed-off-by: Thomas Diesler <[email protected]>
Signed-off-by: Thomas Diesler <[email protected]>
95c6bd4 to
a7f9187
Compare
closes #45965
closes #45979
closes #45999
closes #46001
closes #46003