Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

[OID4VCI] Resolves all OAuthClient API issues in one PR#46014

Closed
tdiesler wants to merge 2 commits intokeycloak:mainfrom
tdiesler:oauthclient-all
Closed

[OID4VCI] Resolves all OAuthClient API issues in one PR#46014
tdiesler wants to merge 2 commits intokeycloak:mainfrom
tdiesler:oauthclient-all

Conversation

@tdiesler
Copy link
Contributor

@tdiesler tdiesler commented Feb 4, 2026

closes #45965
closes #45979
closes #45999
closes #46001
closes #46003

@mabartos
Copy link
Contributor

mabartos commented Feb 4, 2026

@tdiesler JFYI - It does not close the:

Please update it - you are probably missing some reference to another issue for this PR.

@tdiesler tdiesler force-pushed the oauthclient-all branch 3 times, most recently from 022a94c to 05b1c1e Compare February 4, 2026 17:14
@tdiesler
Copy link
Contributor Author

tdiesler commented Feb 4, 2026

@forkimenjeckayang could you perhaps have a look at this PR or if you prefer the individual ones that address a single API each. In the issue descriptions you'll find the rational about these proposed changes.

You can always meet me on slack for a quick chat.

@tdiesler tdiesler force-pushed the oauthclient-all branch 5 times, most recently from 9af9ac1 to b64b3ea Compare February 6, 2026 08:38
@forkimenjeckayang
Copy link
Contributor

@forkimenjeckayang could you perhaps have a look at this PR or if you prefer the individual ones that address a single API each. In the issue descriptions you'll find the rational about these proposed changes.

You can always meet me on slack for a quick chat.

PS: unfortunately not every PR here is be standalone

Hello @tdiesler
Sorry for the delays, and yes I'll take a look and leave my feedback. Thank you for the work on this

@tdiesler
Copy link
Contributor Author

tdiesler commented Feb 6, 2026

The individual PRs are now stand-alone. I would however prefer if this one gets merged instead (so I and others won't have to resolve unwanted merge conflicts)

@tdiesler tdiesler force-pushed the oauthclient-all branch 3 times, most recently from 5656415 to 0bba0f2 Compare February 6, 2026 15:46
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.MultipleTabsLoginTest#testEmptyBaseUrl

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"#account"}
  (Session info: chrome=144.0.7559.109)
For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Build info: version: '4.28.1', revision: '73f5ad48a2'
...

Report flaky test

@tdiesler tdiesler closed this Feb 13, 2026
@tdiesler tdiesler deleted the oauthclient-all branch February 13, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants