Fix duplicate header in VERIFY_EMAIL flow #46106
Open
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddfc5d7 to
f8398fa
Compare
tagliala
commented
Feb 8, 2026
| emailSendErrorMessage=Failed to send email, please try again later. | ||
|
|
||
| accountUpdatedTitle=Account Updated | ||
| accountUpdatedMessage=Your account has been updated. |
Contributor
Author
There was a problem hiding this comment.
Probably this is required somewhere else, but I'm not familiar with the process
f8398fa to
e102c16
Compare
095af22 to
1a36c8c
Compare
When executing the VERIFY_EMAIL action (for example via the admin API), the confirmation page showed "Your account has been updated." twice, once as the page header and once as the body. The root cause is that `AuthenticationManager.finishedRequiredActions()` rendered the `ACCOUNT_UPDATED` info page without setting a messageHeader attribute. The `info.ftl` template falls back to `message.summary` when `messageHeader` is not set, which produced the duplicated message. Change summary: - Add a new message key `accountUpdatedTitle` with value "Account Updated". - Add a Messages constant (`ACCOUNT_UPDATED_TITLE`) for the new key. - Update `AuthenticationManager` to set the `messageHeader` attribute to the message key (`ACCOUNT_UPDATED_TITLE`) instead of passing a resolved message string. Passing the key lets the template render a distinct header (localized via the message key) and keeps the body message separate. Result: - Header now reads "Account Updated" - Body now reads "Your account has been updated." - Prevents the same message appearing both in the header and the body. Notes: - This addresses the same underlying issue reported in keycloak#41701 Fix keycloak#46105 Signed-off-by: Geremia Taglialatela <[email protected]> Update tests to expect new "Account Updated" page title Updated UserEmailTest assertions to expect "Account Updated" instead of "Your account has been updated." for the kc-page-title element (header). The body message still shows "Your account has been updated." - only the header was changed to be shorter and more concise. Fixed tests: - sendResetPasswordEmailWithRedirect (line 617) - sendResetPasswordEmailWithRedirectAndCustomLifespan (line 699) Co-authored-by: tagliala <[email protected]> Lowercase message
1a36c8c to
5139c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing the VERIFY_EMAIL action (for example via the admin API), the confirmation page showed "Your account has been updated." twice, once as the page header and once as the body.
The root cause is that
AuthenticationManager.finishedRequiredActions()rendered theACCOUNT_UPDATEDinfo page without setting a messageHeader attribute.The
info.ftltemplate falls back tomessage.summarywhenmessageHeaderis not set, which produced the duplicated message.Change summary:
accountUpdatedTitlewith value "Account Updated".ACCOUNT_UPDATED_TITLE) for the new key.AuthenticationManagerto set themessageHeaderattribute to the message key (ACCOUNT_UPDATED_TITLE) instead of passing a resolved message string. Passing the key lets the template render a distinct header (localized via the message key) and keeps the body message separate.Result:
Notes:
Fix #46105
Before
After