Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Fix duplicate header in VERIFY_EMAIL flow #46106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tagliala wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

Fix duplicate header in VERIFY_EMAIL flow #46106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions services/src/main/java/org/keycloak/services/managers/AuthenticationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,6 +1088,7 @@ public static Response finishedRequiredActions(KeycloakSession session, Authenti

if (authSession.getAuthNote(END_AFTER_REQUIRED_ACTIONS) != null) {
LoginFormsProvider infoPage = session.getProvider(LoginFormsProvider.class).setAuthenticationSession(authSession)
.setAttribute("messageHeader", Messages.ACCOUNT_UPDATED_TITLE)
.setSuccess(Messages.ACCOUNT_UPDATED);
if (authSession.getAuthNote(SET_REDIRECT_URI_AFTER_REQUIRED_ACTIONS) != null) {
if (authSession.getRedirectUri() != null) {
Expand Down
2 changes: 2 additions & 0 deletions services/src/main/java/org/keycloak/services/messages/Messages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ public class Messages {

public static final String ACCOUNT_UPDATED = "accountUpdatedMessage";

public static final String ACCOUNT_UPDATED_TITLE = "accountUpdatedTitle";

public static final String ACCOUNT_PASSWORD_UPDATED = "accountPasswordUpdatedMessage";

public static final String NO_ACCESS = "noAccessMessage";
Expand Down
4 changes: 2 additions & 2 deletions tests/base/src/test/java/org/keycloak/tests/admin/user/UserEmailTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ public void sendResetPasswordEmailWithRedirect() throws IOException {

passwordUpdatePage.changePassword("new-pass", "new-pass");

assertEquals("Your account has been updated.", driver.findElement(By.id("kc-page-title")).getText());
assertEquals("Account updated", driver.findElement(By.id("kc-page-title")).getText());

String pageSource = driver.page().getPageSource();

Expand Down Expand Up @@ -696,7 +696,7 @@ public void sendResetPasswordEmailWithRedirectAndCustomLifespan() throws IOExcep

passwordUpdatePage.changePassword("new-pass", "new-pass");

assertEquals("Your account has been updated.", driver.findElement(By.id("kc-page-title")).getText());
assertEquals("Account updated", driver.findElement(By.id("kc-page-title")).getText());

String pageSource = driver.page().getPageSource();

Expand Down
1 change: 1 addition & 0 deletions themes/src/main/resources/theme/base/login/messages/messages_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ linkIdpMessage=You need to verify your email address to link your account with {
emailSentMessage=You should receive an email shortly with further instructions.
emailSendErrorMessage=Failed to send email, please try again later.

accountUpdatedTitle=Account updated
accountUpdatedMessage=Your account has been updated.
Copy link
Contributor Author

@tagliala tagliala Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this is required somewhere else, but I'm not familiar with the process

accountPasswordUpdatedMessage=Your password has been updated.

Expand Down
Loading